Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krb5: add linux keyring support #45360

Merged
merged 1 commit into from Aug 21, 2018
Merged

krb5: add linux keyring support #45360

merged 1 commit into from Aug 21, 2018

Conversation

copumpkin
Copy link
Member

This requires some minor hoop-hopping because it's involved in the Linux bootstrap, but it's nothing too complicated.

Fixes #43289

Motivation for this change

It's a useful feature, a bunch of stuff uses kerberos, and it's annoying to inject the dependency into everything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: krb5

Partial log (click to expand)

these paths will be fetched (0.80 MiB download, 2.50 MiB unpacked):
  /nix/store/j7w06rw1dkka7c8zxa5px93nzf9ndl5x-krb5-1.15.2
copying path '/nix/store/j7w06rw1dkka7c8zxa5px93nzf9ndl5x-krb5-1.15.2' from 'https://cache.nixos.org'...
/nix/store/j7w06rw1dkka7c8zxa5px93nzf9ndl5x-krb5-1.15.2

@copumpkin
Copy link
Member Author

Mmm @GrahamcOfBorg I agree, that's a lot of Linux builds. To staging it goes!

@copumpkin
krb5: add linux keyring support
a5b5536 
This requires some minor hoop-hopping because it's involved in the
Linux bootstrap, but it's nothing too complicated.

Fixes NixOS#43289
@copumpkin copumpkin changed the base branch from master to staging August 20, 2018 02:42
@copumpkin
Copy link
Member Author

I'd also like to backport this to 18.03 if nobody objects.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: krb5

Partial log (click to expand)

shrinking /nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev/bin/ksu
shrinking /nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev/bin/uuclient
shrinking /nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev/bin/sim_client
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev/lib  /nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev/bin
patching script interpreter paths in /nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev
/nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev/bin/compile_et: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev/bin/k5srvutil: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev/bin/krb5-config: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/8c0q7r0z0nrp1qpk4mn39fqmwarpyywz-krb5-1.15.2-dev...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: krb5

Partial log (click to expand)

shrinking /nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev/bin/ktutil
shrinking /nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev/bin/kadmin
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev/lib  /nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev/bin
patching script interpreter paths in /nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev
/nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev/bin/krb5-config: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
/nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev/bin/k5srvutil: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
/nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev/bin/compile_et: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/07dflyg3gms451bm94ybv7vp22q1fz3d-krb5-1.15.2-dev...
/nix/store/fx2lwq6r7dcjq82kalj4g9qqm3j149l3-krb5-1.15.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: krb5

Partial log (click to expand)

shrinking /nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev/bin/ktutil
shrinking /nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev/bin/ksu
shrinking /nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev/bin/kdestroy
/nix/store/n46a0fr3h4nhj5rhg557ly7idmxpmrjq-binutils-2.30/bin/strip is /nix/store/n46a0fr3h4nhj5rhg557ly7idmxpmrjq-binutils-2.30/bin/strip
stripping (with command /nix/store/n46a0fr3h4nhj5rhg557ly7idmxpmrjq-binutils-2.30/bin/strip and flags -S) in /nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev/lib  /nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev/bin
patching script interpreter paths in /nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev
/nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev/bin/compile_et: interpreter directive changed from "/bin/sh" to "/nix/store/yjlyjaq76a61w48ky4x0hs5kmwzh9kwn-bash-4.4-p23/bin/sh"
/nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev/bin/krb5-config: interpreter directive changed from "/bin/sh" to "/nix/store/yjlyjaq76a61w48ky4x0hs5kmwzh9kwn-bash-4.4-p23/bin/sh"
/nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev/bin/k5srvutil: interpreter directive changed from "/bin/sh" to "/nix/store/yjlyjaq76a61w48ky4x0hs5kmwzh9kwn-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/nlb81bxzi5r465pw9wzsbnkdkkgjgpzl-krb5-1.15.2-dev...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: krb5

Partial log (click to expand)

cannot build derivation '/nix/store/84hnm12vg1yn909rdd1gpj6wa90qw2i5-libtool-2.4.6.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/29qc1xllpyzm7plr3ycvppxm9kl0hyhq-hook.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/nf8rypaqcc40k30b6rq2sphnr98r4cm0-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/jd9ijf95gd3jg9p1k71zrajf7ysxbni5-groff-1.22.3.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/jr1gz1qggr2v4x885nwpr0nmqnr05949-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/694hdc09qk16yg890b2bkclg43crkf3m-libkrb5-1.15.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/1qg9hgiw6x8pxsl3jhwrs804ai0y2rvf-cyrus-sasl-2.1.26.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/2fx6wdpdrshjlswzwr2p52achn13nrjv-openldap-2.4.46.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/67zc3nv3vyfpp4qm3gwk0pb5clgk2761-krb5-1.15.2.drv': 9 dependencies couldn't be built
error: build of '/nix/store/67zc3nv3vyfpp4qm3gwk0pb5clgk2761-krb5-1.15.2.drv' failed

@copumpkin copumpkin mentioned this pull request Aug 20, 2018
Merged
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: krb5

Partial log (click to expand)

shrinking /nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev/bin/ktutil
shrinking /nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev/bin/kadmin
/nix/store/3bq0zgzfmfynpkwxs0f6r5xrasi987ps-binutils-2.30/bin/strip is /nix/store/3bq0zgzfmfynpkwxs0f6r5xrasi987ps-binutils-2.30/bin/strip
stripping (with command /nix/store/3bq0zgzfmfynpkwxs0f6r5xrasi987ps-binutils-2.30/bin/strip and flags -S) in /nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev/lib  /nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev/bin
patching script interpreter paths in /nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev
/nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev/bin/krb5-config: interpreter directive changed from "/bin/sh" to "/nix/store/pn25sii0c80bics4wbis6wl8411zp5v9-bash-4.4-p23/bin/sh"
/nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev/bin/k5srvutil: interpreter directive changed from "/bin/sh" to "/nix/store/pn25sii0c80bics4wbis6wl8411zp5v9-bash-4.4-p23/bin/sh"
/nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev/bin/compile_et: interpreter directive changed from "/bin/sh" to "/nix/store/pn25sii0c80bics4wbis6wl8411zp5v9-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/kyz2qxqr7ph7y87596lpb542n30lnd2q-krb5-1.15.2-dev...
/nix/store/0m8rfj78v5xyzc15v6rw5yi6snm5hffy-krb5-1.15.2

@copumpkin
Copy link
Member Author

cc @vcunat @nh2 @bgamari @Mic92 as folks who have touched krb5 fairly recently 😄

@vcunat
Copy link
Member

vcunat commented Aug 21, 2018

No objection from me.

@copumpkin copumpkin merged commit 794cfa7 into NixOS:staging Aug 21, 2018
@copumpkin
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: community feedback 10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@copumpkin @GrahamcOfBorg @vcunat