Fix backblaze CLI bash autocomplete issue #45334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One minor thing though: Can you format your commit message according to the Contribution Guidelines? So that is has a |
Backblaze's CLI tool is relying on `have` function which is deprecated[1] and gets dereferenced[2] at the end of `bash-completion`. This causes issues for NixOS because those bash completions are run after bash-completion[3] has already run and unset the `have` function. [1] https://github.com/scop/bash-completion/blob/4d88339928aa064a567d5feb40694dfd24a274c5/bash_completion#L114 [2] https://github.com/scop/bash-completion/blob/4d88339928aa064a567d5feb40694dfd24a274c5/bash_completion#L2103 [3] https://github.com/NixOS/nixpkgs/blob/80b6513fbf5789ff0208c19a89bae49df2b503ad/nixos/modules/programs/bash/bash.nix#L22
uskudnik
force-pushed
the
fix-backblaze-autocompletion-issue
branch
from
6b9dc5e
to
af55116
Compare
|
@infinisil Ah forgot about that one, amended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backblaze's CLI tool is relying on
havefunction which isdeprecated and gets de-referenced at the end of
bash-completion.This causes issues for NixOS because those bash completions are
run after bash-completion has already run and unset the
havefunction.I have submitted patch upstream but I suspect it will take a while before new version is released so I think we should patch it on our end in the meanwhile.
Motivation for this change
Without the patch every time bash is opened:
because
havehas been unset already because it's deprecated (see description).Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)