Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim-qt: fix msgpack dependency, disable failing test, Darwin #45342

Merged
merged 1 commit into from Aug 19, 2018
Merged

neovim-qt: fix msgpack dependency, disable failing test, Darwin #45342

merged 1 commit into from Aug 19, 2018

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Noticed it was broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg build neovim-qt

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neovim-qt

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/agmx61sxcrcd5252pyh97llxsvm7qm1c-neovim-qt-0.2.8
shrinking /nix/store/agmx61sxcrcd5252pyh97llxsvm7qm1c-neovim-qt-0.2.8/bin/.nvim-qt-wrapped
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/agmx61sxcrcd5252pyh97llxsvm7qm1c-neovim-qt-0.2.8/bin
patching script interpreter paths in /nix/store/agmx61sxcrcd5252pyh97llxsvm7qm1c-neovim-qt-0.2.8
checking for references to /build in /nix/store/agmx61sxcrcd5252pyh97llxsvm7qm1c-neovim-qt-0.2.8...
postPatchMkspecs
/nix/store/agmx61sxcrcd5252pyh97llxsvm7qm1c-neovim-qt-0.2.8

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: neovim-qt

Partial log (click to expand)

        [C]: in function 'match'
        /build/source/src/nvim/generators/gen_declarations.lua:255: in main chunk
        [C]: at 0x00405660
make[2]: *** [src/nvim/CMakeFiles/nvim.dir/build.make:379: src/nvim/auto/ex_cmds.c.generated.h] Error 1
make[1]: *** [CMakeFiles/Makefile2:2865: src/nvim/CMakeFiles/nvim.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/fw0z0jpsm07y6rvgralcd6hi4p90pisa-neovim-unwrapped-0.3.1.drv' failed with exit code 2
cannot build derivation '/nix/store/2b3vl1y8w0di94ykvnhp9agl4x4ls5hw-neovim-0.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5n5649ffaiz5brfbna9l1q3j53l2ddyn-neovim-qt-0.2.8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5n5649ffaiz5brfbna9l1q3j53l2ddyn-neovim-qt-0.2.8.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: neovim-qt

Partial log (click to expand)

-- Installing: /nix/store/rj6kyf5wsib982vc57ii5xywdg4pz8gg-neovim-qt-0.2.8/bin/nvim-qt.app/Contents/Resources/runtime/doc
-- Installing: /nix/store/rj6kyf5wsib982vc57ii5xywdg4pz8gg-neovim-qt-0.2.8/bin/nvim-qt.app/Contents/Resources/runtime/doc/nvim_gui_shim.txt
-- Installing: /nix/store/rj6kyf5wsib982vc57ii5xywdg4pz8gg-neovim-qt-0.2.8/bin/nvim-qt.app/Contents/Resources/runtime/doc/tags
-- Installing: /nix/store/rj6kyf5wsib982vc57ii5xywdg4pz8gg-neovim-qt-0.2.8/bin/nvim-qt.app/Contents/Resources/neovim.icns
-- Installing: /nix/store/rj6kyf5wsib982vc57ii5xywdg4pz8gg-neovim-qt-0.2.8/bin/nvim-qt.app/Contents/Info.plist
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/rj6kyf5wsib982vc57ii5xywdg4pz8gg-neovim-qt-0.2.8
postPatchMkspecs
/nix/store/rj6kyf5wsib982vc57ii5xywdg4pz8gg-neovim-qt-0.2.8

infinisil
infinisil approved these changes Aug 19, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aarch has been failing before already

Thanks!

@infinisil infinisil merged commit e1f6688 into NixOS:master Aug 19, 2018
@thefloweringash thefloweringash deleted the neovim-qt-msgpack branch September 24, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @infinisil @GrahamcOfBorg