Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyslurm: 20180604 -> 20180811 #46187

Merged
merged 1 commit into from Sep 7, 2018
Merged

pythonPackages.pyslurm: 20180604 -> 20180811 #46187

merged 1 commit into from Sep 7, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Sep 6, 2018

Update version to support latest version of slurm. Fixes since
previously did not build.

Motivation for this change

18.09 Zero Hydra Failures #45960

Things done

pythonPackages.pyslurm: 20180604 -> 20180811

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
pythonPackages.pyslurm: 20180604 -> 20180811
afab868 
Update version to support latest version of slurm. Fixes since
previously did not build.
@costrouc costrouc requested a review from FRidh as a code owner September 6, 2018 19:10
@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

@markuskowa , maybe this helps with #45925 ?

@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

@GrahamcOfBorg build python27Packages.pyslurm python36Packages.pyslurm

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pyslurm, python36Packages.pyslurm

Partial log (click to expand)

/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/aynpdp95n044hl2gxjkpsy4xd8mbijk4-python3.6-pyslurm-20180811
shrinking /nix/store/aynpdp95n044hl2gxjkpsy4xd8mbijk4-python3.6-pyslurm-20180811/lib/python3.6/site-packages/pyslurm/pyslurm.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aynpdp95n044hl2gxjkpsy4xd8mbijk4-python3.6-pyslurm-20180811/lib
patching script interpreter paths in /nix/store/aynpdp95n044hl2gxjkpsy4xd8mbijk4-python3.6-pyslurm-20180811
checking for references to /build in /nix/store/aynpdp95n044hl2gxjkpsy4xd8mbijk4-python3.6-pyslurm-20180811...
/nix/store/1qy9906dnlfk494yw8gl4wrzwi99x9kj-python2.7-pyslurm-20180811
/nix/store/aynpdp95n044hl2gxjkpsy4xd8mbijk4-python3.6-pyslurm-20180811

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.pyslurm, python36Packages.pyslurm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pyslurm, python36Packages.pyslurm

Partial log (click to expand)

/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7zvh66z1d4f1080n0ndmg67j5gfiacbv-python3.6-pyslurm-20180811
shrinking /nix/store/7zvh66z1d4f1080n0ndmg67j5gfiacbv-python3.6-pyslurm-20180811/lib/python3.6/site-packages/pyslurm/pyslurm.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7zvh66z1d4f1080n0ndmg67j5gfiacbv-python3.6-pyslurm-20180811/lib
patching script interpreter paths in /nix/store/7zvh66z1d4f1080n0ndmg67j5gfiacbv-python3.6-pyslurm-20180811
checking for references to /build in /nix/store/7zvh66z1d4f1080n0ndmg67j5gfiacbv-python3.6-pyslurm-20180811...
/nix/store/z8lwb3g16w44gpfi9kyliyfnaxx5igk8-python2.7-pyslurm-20180811
/nix/store/7zvh66z1d4f1080n0ndmg67j5gfiacbv-python3.6-pyslurm-20180811

@xeji xeji merged commit b1d6d15 into NixOS:master Sep 7, 2018
xeji pushed a commit that referenced this pull request Sep 7, 2018
@costrouc @xeji
pythonPackages.pyslurm: 20180604 -> 20180811 (#46187)
796c736 
Update version to support latest version of slurm. Fixes since
previously did not build.

(cherry picked from commit b1d6d15)
@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

backported: 796c736

@markuskowa
Copy link
Member

@xeji this version does not support 18.08 yet. But it looks like the pySlurm maintainers are working on it.

@costrouc
Copy link
Member Author

costrouc commented Sep 7, 2018

@markuskowa this commit says that they added support 27 days ago? I could be wrong. PySlurm/pyslurm@2d4f055

@markuskowa
Copy link
Member

@costrouc The commit introduced support for 17.11.9. I was trying to update to slurm to 18.08 on nixpkgs /master (#45925)

@costrouc
Copy link
Member Author

costrouc commented Sep 7, 2018 •
edited

You are completely right sorry. It looks like they limit the version support. That latest commit just incremented the max version __max_slurm_hex_version__ = "0x110b09".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @xeji @GrahamcOfBorg @markuskowa