Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: a278414b32ad
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 24209d29f08c
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Sep 6, 2018

  1. top-level, stdenv: Make system and stdenv.system describe the hos…

    …tPlatform.
    
    Intuitively, one cares mainly about the host platform: Platforms differ
    in meaningful ways but compilation is morally a pure process and
    probably doesn't care, or those difference are already abstracted away.
    @dezgeg also empirically confirmed that > 95% of checks are indeed of
    the host platform.
    
    Yet these attributes in the old cross infrastructure were defined to be
    the build platform, for expediency. And this was never before changed.
    (For native builds build and host coincide, so it isn't clear what the
    intention was.)
    
    Fixing this doesn't affect native builds, since again they coincide. It
    also doesn't affect cross builds of anything in Nixpkgs, as these are no
    longer used. It could affect external cross builds, but I deem that
    unlikely as anyone thinking about cross would use more explicit
    attributes for clarity, all the more so because the rarity of inspecting
    the build platform.
    Ericson2314 committed Sep 6, 2018
    Copy the full SHA
    773233c View commit details
    Browse the repository at this point in the history
  2. doc: Add changelog entry for new definition of system and `stdenv.s…

    …ystem`
    
    See the previous commit for details.
    Ericson2314 committed Sep 6, 2018
    Copy the full SHA
    8ae2703 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #46148 from obsidiansystems/plain-system-host

    top-level, stdenv: Make `system` and `stdenv.system` describe the hostPlatform
    John Ericson committed Sep 6, 2018
    Copy the full SHA
    24209d2 View commit details
    Browse the repository at this point in the history