Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox, firefox-bin: 61.0.2 -> 62.0, firefox-esr: 60.1.0esr -> 60.2.0esr, remove 52.9.0esr [Critical security fixes] #46157

Merged
merged 3 commits into from Sep 7, 2018
Merged

firefox, firefox-bin: 61.0.2 -> 62.0, firefox-esr: 60.1.0esr -> 60.2.0esr, remove 52.9.0esr [Critical security fixes] #46157

merged 3 commits into from Sep 7, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Sep 6, 2018

Motivation for this change
  • Critical security fixes
  • Various improvements
  • 52.x ESR is no longer supported

https://www.mozilla.org/en-US/firefox/62.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2018-20/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Sep 6, 2018

Please don't remove 52, this is being tracked in #45787.

@oxij
Copy link
Member

oxij commented Sep 6, 2018 via email

@taku0
Copy link
Contributor Author

taku0 commented Sep 6, 2018

Marked 52.9.0 as insecure #45787 (comment) .

@7c6f434c 7c6f434c merged commit f9a0679 into NixOS:master Sep 7, 2018
@andir andir mentioned this pull request Sep 9, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@taku0 @orivej @oxij @7c6f434c @GrahamcOfBorg