Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages:ordered-set: refactor #46183

Merged
merged 1 commit into from Sep 7, 2018
Merged

pythonPackages:ordered-set: refactor #46183

merged 1 commit into from Sep 7, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Sep 6, 2018

missing dependency for doing tests (pytestrunner) added three months
ago June rspeer/ordered-set@c0b9308.

Motivation for this change

18.09 Zero Hydra Failures #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
pythonPackages:ordered-set: refactor
18d9b12 
missing dependency for doing tests (pytestrunner) added three months
ago June rspeer/ordered-set@c0b9308.
@costrouc costrouc requested a review from FRidh as a code owner September 6, 2018 18:31
@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

@GrahamcOfBorg build python36Packages.ordered-set python27Packages.ordered-set

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.ordered-set, python27Packages.ordered-set

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/ordered-set-3.0.1, inifile:
collected 28 items

test.py ............................                                     [100%]

========================== 28 passed in 0.45 seconds ===========================
/nix/store/pp3gny5i1mkkyyksdswj8fv1fvw2ck00-python3.6-ordered-set-3.0.1
/nix/store/52hf2pgfkdv0cxk8as8zbkcb2p58qhr7-python2.7-ordered-set-3.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.ordered-set, python27Packages.ordered-set

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/ordered-set-3.0.1, inifile:
collected 28 items

test.py ............................                                     [100%]

========================== 28 passed in 0.86 seconds ===========================
/nix/store/kzb8jxi6p910v3qa6fj5v3wj5ywvah3s-python3.6-ordered-set-3.0.1
/nix/store/g2nh1xqnqvkb95n22yif8j0h0p77q5m8-python2.7-ordered-set-3.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.ordered-set, python27Packages.ordered-set

Partial log (click to expand)

/nix/store/h09ihls755vdy4g74wym9c32sygj0q3n-python3.6-ordered-set-3.0.1
/nix/store/zvadj3mlrag58khd69iychkcgn2yxi4v-python2.7-ordered-set-3.0.1

@xeji xeji merged commit 427e491 into NixOS:master Sep 7, 2018
@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

@costrouc please make your commit messages and PR titles a little more specific in the future.
"refactor" is a rather generic term. E.g. , for this one, "add missing dependency" would give people a better idea of what's happening.

xeji pushed a commit that referenced this pull request Sep 7, 2018
@costrouc @xeji
pythonPackages.ordered-set: add missing dependency (#46183)
a16ba12 
missing dependency for doing tests (pytestrunner) added three months
ago June rspeer/ordered-set@c0b9308.

(cherry picked from commit 427e491)
@costrouc
Copy link
Member Author

costrouc commented Sep 7, 2018

@xeji thank you foe the input and I will do that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @xeji @GrahamcOfBorg