Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jupyterlab_launcher: refactor #46178

Merged
merged 1 commit into from Sep 6, 2018
Merged

pythonPackages.jupyterlab_launcher: refactor #46178

merged 1 commit into from Sep 6, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Sep 6, 2018 •
edited

jupyterlab_launcher does not support python version < 3.5. Disabled
for older versions. See https://pypi.org/project/jupyterlab-launcher/#description

Motivation for this change

18.09 Zero Hydra Failures #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
pythonPackages.jupyterlab_launcher: refactor
522e754 
jupyterlab_launcher does not support python version < 3.5. Disabled
for older versions
@costrouc costrouc requested a review from FRidh as a code owner September 6, 2018 18:08
@xeji
Copy link
Contributor

xeji commented Sep 6, 2018

Let's check it worked
@GrahamcOfBorg build python27Packages.jupyterlab_launcher python36Packages.jupyterlab_launcher

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.jupyterlab_launcher

The following builds were skipped because they don't evaluate on aarch64-linux: python27Packages.jupyterlab_launcher

Partial log (click to expand)

copying path '/nix/store/cwxv6p53qcyc3s71ygrmc6wnb4h563yx-python3.6-prompt_toolkit-1.0.15' from 'https://cache.nixos.org'...
copying path '/nix/store/0knsrd1ijbsbfsrhlipw5dgwnagq10vw-python3.6-ipython-6.5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/q1xv1837p13mylq8qwscpvh6dsk782nd-python3.6-jupyter_core-4.4.0' from 'https://cache.nixos.org'...
copying path '/nix/store/kn5mqf9yip6hxrmgw4pflxmw66zrhfq2-python3.6-jupyter_client-5.2.3' from 'https://cache.nixos.org'...
copying path '/nix/store/0kji84smvgqcgwx5jnwfp6zl9kdgcrr3-python3.6-nbformat-4.4.0' from 'https://cache.nixos.org'...
copying path '/nix/store/3bmzs7fpkbwc6xijhrpljm3gcfn5kna3-python3.6-ipykernel-4.8.2' from 'https://cache.nixos.org'...
copying path '/nix/store/w3nn53b9zbdp1rdj6blfh11lcqxf3z29-python3.6-nbconvert-5.3.1' from 'https://cache.nixos.org'...
copying path '/nix/store/nyvxkzac1lj7pqk51i6gr4y9bz3drd9i-python3.6-notebook-5.6.0' from 'https://cache.nixos.org'...
copying path '/nix/store/rj6k61ra14gmm2mwxmxdrrnw5pn6zyhm-python3.6-jupyterlab_launcher-0.13.1' from 'https://cache.nixos.org'...
/nix/store/rj6k61ra14gmm2mwxmxdrrnw5pn6zyhm-python3.6-jupyterlab_launcher-0.13.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.jupyterlab_launcher

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.jupyterlab_launcher

Partial log (click to expand)

copying path '/nix/store/jx5zbfxcl2r9vw8iiw5fzwwhzldss3px-python3.6-pyzmq-17.1.2' from 'https://cache.nixos.org'...
copying path '/nix/store/938m4b7rpjrq8di1535qwzhasjzmwdky-python3.6-ipython-6.5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/1a6afaszwb87vfa8dy10mr8r6mry8igp-python3.6-jupyter_core-4.4.0' from 'https://cache.nixos.org'...
copying path '/nix/store/is7ihxyx0ndh4nzcg5y5xfmyf3qsbmr3-python3.6-jupyter_client-5.2.3' from 'https://cache.nixos.org'...
copying path '/nix/store/fi0vnh2fmlcwmpm9li5wcp5ryma1dz3y-python3.6-nbformat-4.4.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ffb4zv4jnxd5zya6zpgcndv9k2wcm0yb-python3.6-ipykernel-4.8.2' from 'https://cache.nixos.org'...
copying path '/nix/store/qvqpigz8a0fp6znm3ijsva1zkzx3hv6h-python3.6-nbconvert-5.3.1' from 'https://cache.nixos.org'...
copying path '/nix/store/9xspwk599ng8z9x131abvja61ps2qgdl-python3.6-notebook-5.6.0' from 'https://cache.nixos.org'...
copying path '/nix/store/q9kb0mphbnikx63qqdv1k2kvvfz965z5-python3.6-jupyterlab_launcher-0.13.1' from 'https://cache.nixos.org'...
/nix/store/q9kb0mphbnikx63qqdv1k2kvvfz965z5-python3.6-jupyterlab_launcher-0.13.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.jupyterlab_launcher

The following builds were skipped because they don't evaluate on x86_64-linux: python27Packages.jupyterlab_launcher

Partial log (click to expand)

copying path '/nix/store/38cfzhxpvk97kahaz525s8wf87a46cfi-python3.6-jupyter_core-4.4.0' from 'https://cache.nixos.org'...
copying path '/nix/store/bz8qx0wfnrkz8jfnf3aaclyvfgj2q279-zeromq-3.2.5' from 'https://cache.nixos.org'...
copying path '/nix/store/fqndazrpdiqcms7ivcqxy8gnmbw3xswx-python3.6-nbformat-4.4.0' from 'https://cache.nixos.org'...
copying path '/nix/store/5kk1n0b1sdxqzs56y6galig2p1yvq8nz-python3.6-pyzmq-17.1.2' from 'https://cache.nixos.org'...
copying path '/nix/store/mldl2xklwa03zc4ppi8ms2p72gyac0r8-python3.6-jupyter_client-5.2.3' from 'https://cache.nixos.org'...
copying path '/nix/store/d70vr7s8v2ncj53mbp2v4w6nb5bk8zzz-python3.6-ipykernel-4.8.2' from 'https://cache.nixos.org'...
copying path '/nix/store/qdivvcm3cqii4bwf609gdpkpas45iapf-python3.6-nbconvert-5.3.1' from 'https://cache.nixos.org'...
copying path '/nix/store/94vqszxlf8basd5s3ni8wf5bq3h8p6x4-python3.6-notebook-5.6.0' from 'https://cache.nixos.org'...
copying path '/nix/store/21lxdak14zn4z4p8pxb4nrsivxfc1xvv-python3.6-jupyterlab_launcher-0.13.1' from 'https://cache.nixos.org'...
/nix/store/21lxdak14zn4z4p8pxb4nrsivxfc1xvv-python3.6-jupyterlab_launcher-0.13.1

@xeji xeji merged commit 7bcc287 into NixOS:master Sep 6, 2018
xeji pushed a commit that referenced this pull request Sep 6, 2018
@costrouc @xeji
pythonPackages.jupyterlab_launcher: refactor (#46178)
b871c68 
jupyterlab_launcher does not support python version < 3.5. Disabled
for older versions

(cherry picked from commit 7bcc287)
@xeji
Copy link
Contributor

xeji commented Sep 6, 2018

backported: b871c68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @xeji @GrahamcOfBorg