Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmw: 0.43.0 -> 0.44.0 #46153

Closed
wants to merge 2 commits into from
Closed

openmw: 0.43.0 -> 0.44.0 #46153

wants to merge 2 commits into from
+3 −3

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2018 •
edited by ghost
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Henry added 2 commits September 6, 2018 09:46
Merge pull request #1 from NixOS/master

Verified

This commit was signed with the committer’s verified signature.
sikmir Nikolay Korotkiy
GPG key ID: D1DE6D7F693663A5
Verified
Learn about vigilant mode
370f5d1 
Update local fork
Bump to latest stable release (0.44.0)
dc9a354
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 6, 2018
@ghost ghost changed the title openmw: bump to latest stable release (0.44.0) openmw: 0.43.0 -> 0.44..0 Sep 7, 2018
@ghost ghost changed the title openmw: 0.43.0 -> 0.44..0 openmw: 0.43.0 -> 0.44.0 Sep 7, 2018
@matthewbauer
Copy link
Member

@GrahamcOfBorg build openmw

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openmw

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openmw

Partial log (click to expand)

shrinking /nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0/bin/openmw-iniimporter
shrinking /nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0/bin/esmtool
shrinking /nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0/bin/bsatool
shrinking /nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0/bin/openmw-launcher
shrinking /nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0/bin/openmw
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0/bin
patching script interpreter paths in /nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0
checking for references to /build in /nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0...
/nix/store/j03zi0ggwmd1g570rkw86711lzwzjd8n-openmw-0.44.0

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: openmw

Partial log (click to expand)

[ 75%] Building CXX object apps/opencs/CMakeFiles/openmw-cs.dir/view/world/nestedtable.cpp.o
[ 75%] Building CXX object apps/opencs/CMakeFiles/openmw-cs.dir/view/world/dialoguespinbox.cpp.o
[ 75%] Building CXX object apps/opencs/CMakeFiles/openmw-cs.dir/view/world/recordbuttonbar.cpp.o
[ 75%] Building CXX object apps/opencs/CMakeFiles/openmw-cs.dir/view/world/tableeditidaction.cpp.o
[ 75%] Building CXX object apps/opencs/CMakeFiles/openmw-cs.dir/view/world/scripterrortable.cpp.o
[ 75%] Building CXX object apps/opencs/CMakeFiles/openmw-cs.dir/view/world/extendedcommandconfigurator.cpp.o
[ 75%] Building CXX object apps/opencs/CMakeFiles/openmw-cs.dir/view/world/bodypartcreator.cpp.o
[ 76%] Building CXX object apps/opencs/CMakeFiles/openmw-cs.dir/view/world/landtexturecreator.cpp.o
building of '/nix/store/y6gd8m03q6qy364kqhssjmzag1yzvfmr-openmw-0.44.0.drv' timed out after 3600 seconds
error: build of '/nix/store/y6gd8m03q6qy364kqhssjmzag1yzvfmr-openmw-0.44.0.drv' failed

@peterhoeg
Copy link
Member

peterhoeg commented Sep 30, 2018 •
edited
Loading

OpenMW has also had support for qt5 for the longest time - let's take this opportunity to move to that instead of qt4.

You can use these for reference: 3cf8812 and 99d7528

@ghost
Copy link
Author

ghost commented Nov 11, 2018

@peterhoeg Forgot about this account sorry... & thanks for the comment. I'm probably capable of those changes after reviewing a bunch of stuff, but I am considering refraining from touching master until I am more familiar with a large code base like this (just a hobbyist/student now).

Would you mind advising me on good practices re: closing the PR or maybe pointing me to pertinent project guidelines if you can? Thanks for your time

@peterhoeg
Copy link
Member

I am considering refraining from touching master

You are not able to merge directly to master - if you open a PR we will review it before it gets merged, so you do not have to worry about that.

pointing me to pertinent project guidelines

If you have a look at the 2 commits I referenced above, you can see how qt4 -> qt5 could be done.

We need all the contributors we can, so if you feel that you're up to it, please give it a go and feel free to ping me for input.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/bump-openmw-0-44-0-and-ported-to-qt5/2121/1

@geekware geekware mentioned this pull request Feb 14, 2019
Closed
10 tasks
@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build openmw

@veprbl veprbl mentioned this pull request Mar 12, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthewbauer @GrahamcOfBorg @peterhoeg @nixos-discourse @ryantm