Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix 2.1 on 18.09 #46192

Merged
merged 3 commits into from Sep 6, 2018
Merged

Nix 2.1 on 18.09 #46192

merged 3 commits into from Sep 6, 2018

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 6, 2018

Motivation for this change

Nix 2.1 on 18.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member Author

grahamc commented Sep 6, 2018

@GrahamcOfBorg build nix nix-plugins

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix, nix-plugins

Partial log (click to expand)

-- Installing: /nix/store/qds53k4bvgbl78c001bjzryg8cgfac0c-nix-plugins-5.0.0/lib/nix/plugins/libnix-extra-builtins.so
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qds53k4bvgbl78c001bjzryg8cgfac0c-nix-plugins-5.0.0
shrinking /nix/store/qds53k4bvgbl78c001bjzryg8cgfac0c-nix-plugins-5.0.0/lib/nix/plugins/libnix-extra-builtins.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qds53k4bvgbl78c001bjzryg8cgfac0c-nix-plugins-5.0.0/lib
patching script interpreter paths in /nix/store/qds53k4bvgbl78c001bjzryg8cgfac0c-nix-plugins-5.0.0
checking for references to /build in /nix/store/qds53k4bvgbl78c001bjzryg8cgfac0c-nix-plugins-5.0.0...
/nix/store/xps2684jmj85nak2bzi2ra1laanscxmd-nix-2.1.1
/nix/store/qds53k4bvgbl78c001bjzryg8cgfac0c-nix-plugins-5.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nix, nix-plugins

Partial log (click to expand)

[100%] Built target nix-extra-builtins
Install the project...
-- Install configuration: "Release"
-- Installing: /nix/store/xmsyhapapax3czkcbqxynb8hcn5lf7n8-nix-plugins-5.0.0/lib/nix/plugins/libnix-extra-builtins.dylib
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/xmsyhapapax3czkcbqxynb8hcn5lf7n8-nix-plugins-5.0.0/lib
patching script interpreter paths in /nix/store/xmsyhapapax3czkcbqxynb8hcn5lf7n8-nix-plugins-5.0.0
/nix/store/04a3khpnqisasd5pwwyqb3ck39ys2nxv-nix-2.1.1
/nix/store/xmsyhapapax3czkcbqxynb8hcn5lf7n8-nix-plugins-5.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix, nix-plugins

Partial log (click to expand)

-- Installing: /nix/store/wl2wi7spb5i44mi88mz6vmlh15k814dh-nix-plugins-5.0.0/lib/nix/plugins/libnix-extra-builtins.so
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wl2wi7spb5i44mi88mz6vmlh15k814dh-nix-plugins-5.0.0
shrinking /nix/store/wl2wi7spb5i44mi88mz6vmlh15k814dh-nix-plugins-5.0.0/lib/nix/plugins/libnix-extra-builtins.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wl2wi7spb5i44mi88mz6vmlh15k814dh-nix-plugins-5.0.0/lib
patching script interpreter paths in /nix/store/wl2wi7spb5i44mi88mz6vmlh15k814dh-nix-plugins-5.0.0
checking for references to /build in /nix/store/wl2wi7spb5i44mi88mz6vmlh15k814dh-nix-plugins-5.0.0...
/nix/store/7szlyb3imw7gdy7c270s9s56wgcf1ab7-nix-2.1.1
/nix/store/wl2wi7spb5i44mi88mz6vmlh15k814dh-nix-plugins-5.0.0

@grahamc grahamc merged commit 3d83234 into NixOS:release-18.09 Sep 6, 2018
@grahamc grahamc deleted the nix-2.1-on-18.09 branch September 6, 2018 19:44
@vcunat
Copy link
Member

vcunat commented Sep 6, 2018 •
edited

AFAIK no notable incompatibility should be there, so I guess we don't need a specific entry in 18.09 release notes, and we can e.g. later lump it with information about versions of kernel, gcc, etc.

@samueldr
Copy link
Member

samueldr commented Sep 6, 2018 •
edited

40.1.4. Before the final release

There's the fallback that'll need updating I believe, too. (And as for the release notes, it probably will be mentioned in addition with the minimal version being 2.0, the default being 2.1.1, etc.)

EDIT: make sure to read the PR before commenting! (Though to be fair the instructions are changing nixos-rebuild.sh and not nix-fallback-paths.nix.)

@vcunat vcunat mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@grahamc @GrahamcOfBorg @vcunat @samueldr @srhb