Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networkmanager: fix VPN plugin service definition targets #46201

Merged
merged 1 commit into from Sep 8, 2018
Merged

nixos/networkmanager: fix VPN plugin service definition targets #46201

merged 1 commit into from Sep 8, 2018

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

#46197

NetworkManager VPN plugins have moved their nm-${plugin}-service.name files from /etc to /lib.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 6, 2018

cc @flokli

@flokli
Copy link
Contributor

flokli commented Sep 8, 2018

LGTM, fixes it for me too.

@flokli flokli mentioned this pull request Sep 8, 2018
Closed
9 tasks
@xeji xeji merged commit 56b3c5b into NixOS:master Sep 8, 2018
xeji pushed a commit that referenced this pull request Sep 8, 2018
@tadfisher @xeji
nixos/networkmanager: fix VPN plugin service definition targets (#46201)
43c9869 
(cherry picked from commit 56b3c5b)
@xeji xeji mentioned this pull request Sep 8, 2018
Closed
@jtojnar jtojnar mentioned this pull request Sep 13, 2018
Merged
9 tasks
@jerith666
Copy link
Contributor

Is there a way to make the thing that builds the symlinks for environment.etc fail hard if it's asked to build links into derivations that don't exist?

jerith666 pushed a commit to jerith666/nixpkgs that referenced this pull request Sep 13, 2018
@tadfisher @jerith666
nixos/networkmanager: fix VPN plugin service definition targets (NixO…
73e1f1e 
…S#46201)

(cherry picked from commit 56b3c5b)
@jtojnar jtojnar mentioned this pull request Sep 13, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tadfisher @jtojnar @flokli @jerith666 @GrahamcOfBorg @xeji