Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: e0404ef02494
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 7f345622bc51
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Sep 6, 2018

  1. Haskell builder: Use $abi/$libname as --libsubdir 

    (cherry picked from commit a7d8800)
    @shlevy
    Alex Biehl authored and shlevy committed Sep 6, 2018
    Copy the full SHA
    f071c8b View commit details
    Browse the repository at this point in the history

  2. More conservative SCC tagging for Haskell libraries 

    `all-functions` corresponds to `-fprof-auto` which places an SCC on every binding. It is well known that SCCs hinder GHC from doing its optimization magic and really slows down profiled code to a point where the profiling reports are completely skewed towards things that were completely optimized away in production settings. Concretely this shows up with things like lenses which do not carry runtime overhead when properly simplified.

`exported-functions` corresponds to GHCs `-fprof-auto-exported` which doesn't put SCCs on `INLINE`d code and in turn doesn't influence simplification of this basic but important stuff.

(cherry picked from commit 3c70c4c)
    @alexbiehl @shlevy
    alexbiehl authored and shlevy committed Sep 6, 2018
    Copy the full SHA
    f3ced68 View commit details
    Browse the repository at this point in the history

  3. ghc: Apply fix to abi-hash with backpack. 

    See https://phabricator.haskell.org/D5123.

(cherry picked from commit cbf1943)
    @shlevy
    shlevy committed Sep 6, 2018
    Copy the full SHA
    328fc49 View commit details
    Browse the repository at this point in the history

  4. haskell.compiler.ghc861: Apply fix to abi-hash with backpack. 

    See https://phabricator.haskell.org/D5123.

(cherry picked from commit 06a3db6)
    @shlevy
    shlevy committed Sep 6, 2018
    Copy the full SHA
    7f34562 View commit details
    Browse the repository at this point in the history