Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.geopandas: 0.3.0 -> 0.4.0 #46165

Merged
merged 1 commit into from Sep 6, 2018
Merged

pythonPackages.geopandas: 0.3.0 -> 0.4.0 #46165

merged 1 commit into from Sep 6, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Sep 6, 2018

Additionally fix issue with tests failing for 18.09 release.

Tests required url fetch. Disabled with "not web".

Motivation for this change

Fix build in 27 and 36. #45960

Things done

pythonPackages.geopandas: 0.3.0 -> 0.4.0

fix build. Tests now pass.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
pythonPackages.geopandas: 0.3.0 -> 0.4.0
d42a49f 
Additionally fix issue with tests failing for 18.09 release.

Tests required url fetch. Disabled with "not web".
@costrouc costrouc requested a review from FRidh as a code owner September 6, 2018 16:15
@FRidh
Copy link
Member

FRidh commented Sep 6, 2018

@GrahamcOfBorg build python2.pkgs.geopandas python3.pkgs.geopandas

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.geopandas, python3.pkgs.geopandas

Partial log (click to expand)

    other.crs))

geopandas/tests/test_types.py::TestSeries::()::test_select
  /build/source/geopandas/geoseries.py:131: FutureWarning: 'select' is deprecated and will be removed in a future release. You can use .loc[labels.map(crit)] as a replacement
    val = getattr(super(GeoSeries, self), mtd)(*args, **kwargs)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
= 301 passed, 14 skipped, 1 deselected, 7 xfailed, 2 warnings in 35.01 seconds =
/nix/store/a954cr59ybi6scs6dsn83ds3gpn6dcsc-python2.7-geopandas-0.4.0
/nix/store/9587wp189spa5098p8ckymaiml0qrnz0-python3.6-geopandas-0.4.0

@FRidh FRidh merged commit 1d6fd65 into NixOS:master Sep 6, 2018
@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: python2.pkgs.geopandas, python3.pkgs.geopandas

Partial log (click to expand)

cannot build derivation '/nix/store/k8d54sbry62hx1zvs5ddb4dnn4mhlyqw-python2.7-Fiona-1.7.13.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/713nv7zxrw7ggmapjrbjq60h2l49q21i-python3.6-Fiona-1.7.13.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kqwfrljj9k9aap9035dg13bvkinm0q93-python2.7-geopandas-0.4.0.drv': 2 dependencies couldn't be built
................................                                         [ 94%]
../../nix/store/8j80sfr6rmn7yd161v1f0f1zqm28b1g6-python3.6-pandas-0.23.4/lib/python3.6/site-packages/pandas/tests/tseries/offsets/test_ticks.py . [ 94%]
.....................................................................    [ 94%]
../../nix/store/8j80sfr6rmn7yd161v1f0f1zqm28b1g6-python3.6-pandas-0.23.4/lib/python3.6/site-packages/pandas/tests/tseries/offsets/test_yqm_offsets.py . [ 94%]
building of '/nix/store/qa3qf1ckgx2aiq3ngqm1ir2dqqf3wzp1-python3.6-pandas-0.23.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/1yijcwkdlhnbfwnrghnwszvrakwj6168-python3.6-geopandas-0.4.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/1yijcwkdlhnbfwnrghnwszvrakwj6168-python3.6-geopandas-0.4.0.drv', '/nix/store/kqwfrljj9k9aap9035dg13bvkinm0q93-python2.7-geopandas-0.4.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python2.pkgs.geopandas, python3.pkgs.geopandas

Partial log (click to expand)

/nix/store/dlswl7xjvh3bsfydygqzi2n0f82p5d9p-python3-3.6.6/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'metadata_version'
  warnings.warn(msg)
/nix/store/dlswl7xjvh3bsfydygqzi2n0f82p5d9p-python3-3.6.6/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'requires_python'
  warnings.warn(msg)
/nix/store/dlswl7xjvh3bsfydygqzi2n0f82p5d9p-python3-3.6.6/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'requires_external'
  warnings.warn(msg)
error: command 'clang++' failed with exit status 1
builder for '/nix/store/s2icghsvwgzfq87211hf9vb663b12l6b-python3.6-Fiona-1.7.13.drv' failed with exit code 1
cannot build derivation '/nix/store/4kdxc7q3gl8krb8627m2jvmflx5kf1ww-python3.6-geopandas-0.4.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4kdxc7q3gl8krb8627m2jvmflx5kf1ww-python3.6-geopandas-0.4.0.drv', '/nix/store/yrcdwnihc6x9xmc436pgsn5dqcp698kh-python2.7-geopandas-0.4.0.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @FRidh @GrahamcOfBorg