kodi: implement kodiWithPlugins, add more plugins
#46196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @titanous @edwtjo @cpages @worldofpeace from git-blame of |
oxij
force-pushed
the
pkgs/kodi-with-plugins
branch
from
5d296a9
to
f02153c
Compare
oxij
force-pushed
the
pkgs/kodi-with-plugins
branch
from
f02153c
to
f62a31b
Compare
worldofpeace
reviewed
Sep 6, 2018
oxij
force-pushed
the
pkgs/kodi-with-plugins
branch
2 times, most recently
from
025279d
to
ec7d00e
Compare
|
Success on x86_64-linux (full log) Attempted: kodi, kodiPlugins.simpleplugin, kodiPlugins.yatp The following builds were skipped because they don't evaluate on x86_64-linux: kodiPlugins.steam-launcher Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp The following builds were skipped because they don't evaluate on aarch64-linux: kodi, kodiPlugins.steam-launcher Partial log (click to expand)
|
|
with 3.8k rebuilds this should go to staging. |
oxij
force-pushed
the
pkgs/kodi-with-plugins
branch
from
ec7d00e
to
031e1cf
Compare
|
@xeji
Ugh, I see, `pythonPackages.requests` is a mass rebuilt.
I don't want to move this to staging as I rebased this several times already, it touches a lot of kodi stuff and I'm tired of fixing those conflicts.
I removed YATP from here, changes to plugins will go to `staging` after this gets merged to `master`.
@worldofpeace
Please drop this plugin as it no longer exists.
Ok, will do in that second PR.
This is now became a purely infrastructure PR.
|
GrahamcOfBorg
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 501+
10.rebuild-linux: 501+
labels
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: kodi, kodiPlugins.steam-launcher Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kodi The following builds were skipped because they don't evaluate on x86_64-linux: kodiPlugins.steam-launcher Partial log (click to expand)
|
|
I've rebuilt everything (with mass-rebuild YATP patches included) on top of this revision. I can see no issues. LGTM. Merge at will. |
|
@xeji Thanks! |
1 task
|
Changes to plugins: #46403. |
oxij
added a commit
to oxij/nixpkgs
that referenced
this pull request
Nov 7, 2018
No loner exists, I couldn't find an official replacement repo, should be removed according to NixOS#46196 (comment)
FRidh
pushed a commit
that referenced
this pull request
Nov 18, 2018
No loner exists, I couldn't find an official replacement repo, should be removed according to #46196 (comment)
sephalon
pushed a commit
to sephalon/nixpkgs
that referenced
this pull request
Jan 23, 2019
No loner exists, I couldn't find an official replacement repo, should be removed according to NixOS#46196 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I tried to add YATP to Kodi, ended up rewriting a bunch of stuff.
Known issues
I did not touch
wrapKodiand the default wrappedkodi, but, really, we should probably deprecate and then remove it.Things done
kodiwith its configuration vianixpkgs.configand the newkodiWithPluginswork.Don't merge sooner than 2018-09-09 23:59 UTC.Merge at will.