Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.kuberentes: refactor #46179

Merged
merged 1 commit into from Sep 7, 2018
Merged

pythonPackages.kuberentes: refactor #46179

merged 1 commit into from Sep 7, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Sep 6, 2018

fix build issue from missing dependency adal. This is due to adal
being added as a dependency in July
23rd. kubernetes-client/python@9afec55#diff-b4ef698db8ca845e5845c4618278f29a

Motivation for this change

18.09 Zero Hydra Failures #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
pythonPackages.kuberentes: refactor
f89794c 
fix build issue from missing dependency `adal`. This is due to `adal`
being added as a dependency in July
23rd. kubernetes-client/python@9afec55#diff-b4ef698db8ca845e5845c4618278f29a
@costrouc costrouc requested a review from FRidh as a code owner September 6, 2018 18:16
@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

@GrahamcOfBorg build python36Packages.kubernetes python27Packages.kubernetes

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.kubernetes, python27Packages.kubernetes

Partial log (click to expand)

collected 61 items

kubernetes/config/dateutil_test.py ..                                    [  3%]
kubernetes/config/incluster_config_test.py ..........                    [ 19%]
kubernetes/config/kube_config_test.py .................................. [ 75%]
.......                                                                  [ 86%]
kubernetes/stream/ws_client_test.py .                                    [ 88%]
kubernetes/watch/watch_test.py .......                                   [100%]

========================== 61 passed in 3.07 seconds ===========================

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.kubernetes, python27Packages.kubernetes

Partial log (click to expand)

.......                                                                  [ 86%]
kubernetes/stream/ws_client_test.py .                                    [ 88%]
kubernetes/watch/watch_test.py .......                                   [100%]

========================== 61 passed in 15.95 seconds ==========================
kubernetes/watch/watch_test.py .......                                   [100%]

========================== 61 passed in 17.24 seconds ==========================
/nix/store/y5sqf442l4jisi3dfbfijsa1glir4jyp-python3.6-kubernetes-7.0.0
/nix/store/0anr3qdpf4ldhmracdjp2qfy650238k8-python2.7-kubernetes-7.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.kubernetes, python27Packages.kubernetes

Partial log (click to expand)

these derivations will be built:
  /nix/store/fry8402f85pydidabn2p8vbv9crbjsx5-python2.7-kubernetes-7.0.0.drv
waiting for locks or build slots...
/nix/store/gg8hf6kcx5w0pdvjbm80yclfncjb8jhh-python3.6-kubernetes-7.0.0
/nix/store/9gpyaxm31gm23wcb70l3qgp1qnvj35qq-python2.7-kubernetes-7.0.0

@xeji xeji merged commit 66e1288 into NixOS:master Sep 7, 2018
xeji pushed a commit that referenced this pull request Sep 7, 2018
@costrouc @xeji
pythonPackages.kubernetes: add missing dependency (#46179)
5974311 
fix build issue from missing dependency `adal`. This is due to `adal`
being added as a dependency in July
23rd. kubernetes-client/python@9afec55#diff-b4ef698db8ca845e5845c4618278f29a

(cherry picked from commit 66e1288)
@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

backported: 5974311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @xeji @GrahamcOfBorg