wireguard: change preStop to postStop, require network.target #45569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
approved these changes
Aug 24, 2018
|
please see #45392 |
Mic92
reviewed
Aug 24, 2018
| @@ -190,6 +190,7 @@ let | |||
| nameValuePair "wireguard-${name}" | |||
| { | |||
| description = "WireGuard Tunnel - ${name}"; | |||
| requires = [ "network.target" ]; | |||
There was a problem hiding this comment.
network-online.target tries gives you connectivity guarantees.
|
I am merging this first because I am not sure #45392 is ready yet, and we should get at least one of these improvements into 18.09. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
If the wireguard service fails, the teardown script is not executed and it cannot be restarted cleanly, because the device still exists. This changes
preStoptopostStop, in order to execute the teardown script in all cases.Also, if the wireguard service has to do a dns resolve and there is no network available, the service fails to start. Add a 'network.target' requirement.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)