Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todoman: init at 3.4.0 #45570

Merged
merged 2 commits into from Aug 24, 2018
Merged

todoman: init at 3.4.0 #45570

merged 2 commits into from Aug 24, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Aug 24, 2018 •
edited

Motivation for this change

Sisterproject to khal and vdirsyncer for task management on command line, using iCalender files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@leenaars leenaars force-pushed the todoman branch 2 times, most recently from b16efbd to eb469f7 Compare August 24, 2018 12:21
@leenaars
Copy link
Contributor Author

I actually have no idea why this evaluation fails. It builds on NixOS and on other Linux distro's, and there is really nothing 'special' about it.

@xeji
Copy link
Contributor

xeji commented Aug 24, 2018

Hm, not sure, builds locally here. Let's try again
@GrahamcOfBorg eval

xeji
xeji reviewed Aug 24, 2018
View reviewed changes
pkgs/applications/office/todoman/default.nix Outdated

postInstall = ''
wrapProgram "$out/bin/todo" --set LOCALE_ARCHIVE ${glibcLocales}/lib/locale/locale-archive \
--set CHARSET=en_us.UTF-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be --set CHARSET en_us.UTF-8. (the = is wrong). Maybe that causes the eval error.

Also this creates two layers of wrappers (because buildPythonApplication already creates one) which is ugly.
A better solution may be to use makeWrapperArgs = [ "--set LOCALE_ARCHIVE ..." "--set CHARSET ..." ]; instead of the makeWrapper, see other examples in nixpkgs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, did that. Let's see what comes out of it.

@xeji
todoman: limit to linux
2abe395 
glibcLocales doesn't exist on Darwin
@xeji
Copy link
Contributor

xeji commented Aug 24, 2018

@leenaars the eval ssue was that glibcLocales doesn't exist on Darwin. I limited platforms to linux.
@GrahamcOfBorg build todoman

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: todoman

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: todoman

Partial log (click to expand)

todoman/interactive.py        94      0   100%
todoman/model.py             458      0   100%
todoman/version.py             1      0   100%
todoman/widgets.py            94      0   100%
--------------------------------------------------------
TOTAL                       1155      0   100%


============== 167 passed, 5 skipped, 3 xfailed in 21.78 seconds ===============
/nix/store/7g5mv3scn9b7s615d73spkl4v6r07gr3-todoman-3.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: todoman

Partial log (click to expand)

TOTAL                       1155      0   100%


=============================== warnings summary ===============================
tests/test_cli.py::test_sorting_fields
  hypothesis_temporary_module_46495eb1e3b15c65874278296d46e4552d3ba8a2:335: HypothesisDeprecationWarning: Test took 291.92ms to run. In future the default deadline setting will be 200ms, which will make this an error. You can set deadline to an explicit value of e.g. 300 to turn tests slower than this into an error, or you can set it to None to disable this check entirely.

-- Docs: http://doc.pytest.org/en/latest/warnings.html
======== 167 passed, 5 skipped, 3 xfailed, 1 warnings in 91.57 seconds =========
/nix/store/d7as322lqp2csp0nr1990lldzg4k4id7-todoman-3.4.0

@xeji xeji merged commit 740c788 into NixOS:master Aug 24, 2018
@leenaars
Copy link
Contributor Author

Awesome. Thanks!

@leenaars leenaars deleted the todoman branch August 24, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leenaars @xeji @GrahamcOfBorg