pythonPackages.bjoern: init at 2.2.2 #45557

CMCDragonkai · 2018-08-24T08:03:28Z

Motivation for this change

Added bjoern. A screaming fast WSGI server!

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

CMCDragonkai · 2018-08-24T08:05:24Z

@GrahamcOfBorg build pythonPackages.bjoern python3Packages.bjoern

dotlambda · 2018-08-24T08:51:49Z

@CMCDragonkai You'd have to add yourself to https://github.com/NixOS/ofborg/blob/released/config.known-users.json.

@GrahamcOfBorg build python2.pkgs.bjoern python3.pkgs.bjoern

GrahamcOfBorg · 2018-08-24T08:52:24Z

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.bjoern, python3.pkgs.bjoern

Partial log (click to expand)

writing manifest file 'bjoern.egg-info/SOURCES.txt'
running build_ext
copying build/lib.macosx-10.6-x86_64-3.6/_bjoern.cpython-36m-darwin.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/iy318jsb00yjcp45saqps94pl74ha98w-python2.7-bjoern-2.2.2
/nix/store/4minzk63a03mhwk0xmlw5xw1c3sx0jpa-python3.6-bjoern-2.2.2

GrahamcOfBorg · 2018-08-24T08:52:32Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.bjoern, python3.pkgs.bjoern

Partial log (click to expand)

writing manifest file 'bjoern.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-x86_64-3.6/_bjoern.cpython-36m-x86_64-linux-gnu.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/qpw398hxs2g1r1xlcy32d92fpk534zsg-python2.7-bjoern-2.2.2
/nix/store/f3i3imxp7plma0avv36j26yz2rxigixh-python3.6-bjoern-2.2.2

dotlambda · 2018-08-24T08:54:26Z

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase. In case there are no tests, please set doCheck = false and add a comment with the reason.

GrahamcOfBorg · 2018-08-24T08:54:51Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.bjoern, python3.pkgs.bjoern

Partial log (click to expand)

writing manifest file 'bjoern.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-aarch64-2.7/_bjoern.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/vddl57mmpcqigm82advr7pnwaqblchq2-python2.7-bjoern-2.2.2
/nix/store/a15fpdh7zh5lxiwj1wi6l6vhh0k2jrda-python3.6-bjoern-2.2.2

CMCDragonkai · 2018-09-06T05:15:02Z

As can be seen by the linked issue jonashaag/bjoern#140

There are only 2 automated tests, one of them doesn't work since I tried. And both are just scripts.

Both scripts involve binding to localhost 127.0.0.1. Is this OK for running tests? I suppose if the build is happening in a "container" namespace, I'm not sure if the network itself is namespaced as well.

CMCDragonkai · 2018-09-06T05:53:23Z

@dotlambda The first test produces ugly messages that seem to a human user to cause errors, yet it appears that it's not considered a failure of the test itself. What do you think of such things? jonashaag/bjoern#140 (comment)

Also I'm assuming that if a command returned back a non-exit code of 0, the checkPhase would fail right?

CMCDragonkai · 2018-09-06T05:56:14Z

@dotlambda I added one of the tests that doesn't cause ugly messages.

CMCDragonkai · 2018-09-06T07:28:14Z

On author's recommendations, redirected STDERR to /dev/null.

FRidh · 2018-09-06T16:11:09Z

pkgs/development/python-modules/bjoern/default.nix

+  buildInputs = [ libev ];
+
+  checkPhase = ''
+    python tests/keep-alive-behaviour.py 2>/dev/null


${python.interpreter}

CMCDragonkai · 2018-09-10T03:28:53Z

@FRidh Done.

dotlambda · 2018-09-11T12:39:30Z

pkgs/development/python-modules/bjoern/default.nix

+  buildInputs = [ libev ];
+
+  checkPhase = ''
+    ${python.interpreter} tests/keep-alive-behaviour.py 2>/dev/null


I'm not sure it's wise to use 2>/dev/null. Having some information when something goes wrong would be nice, wouldn't it?

The proper way to silence these messages is to pipe the test's subprocesses' stderr to /dev/null, as suggested in the linked GitHub issue.

CMCDragonkai · 2018-09-11T14:17:38Z

Asked this of the creator already. The messages that come out are all exceptions.

…

On 11 September 2018 22:39:35 GMT+10:00, "Robert Schütz" ***@***.***> wrote: dotlambda commented on this pull request. > @@ -0,0 +1,25 @@ +{ stdenv, buildPythonPackage, fetchPypi, libev, python }: + +buildPythonPackage rec { + pname = "bjoern"; + version = "2.2.2"; + + src = fetchPypi { + inherit pname version; + sha256 = "1w5z9agacci4shmkg9gh46ifj2a724rrgbykdv14830f7jq3dcmi"; + }; + + buildInputs = [ libev ]; + + checkPhase = '' + ${python.interpreter} tests/keep-alive-behaviour.py 2>/dev/null I'm not sure it's wise to use `2>/dev/null`. Having some information when something goes wrong would be nice, wouldn't it? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #45557 (review)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

CMCDragonkai · 2018-09-17T14:02:44Z

I'd like to get this merged. I wonder if there's any issues holding this up.

CMCDragonkai requested a review from FRidh as a code owner August 24, 2018 08:03

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 24, 2018

CMCDragonkai mentioned this pull request Aug 24, 2018

Packaging for nix jonashaag/bjoern#140

Closed

CMCDragonkai force-pushed the bjoern branch from add1631 to 42d2fbf Compare September 6, 2018 05:55

CMCDragonkai force-pushed the bjoern branch from 42d2fbf to 0937c93 Compare September 6, 2018 07:27

FRidh requested changes Sep 6, 2018

View reviewed changes

pythonPackages.bjoern: init at 2.2.2

5d5f4c5

CMCDragonkai force-pushed the bjoern branch from 0937c93 to 5d5f4c5 Compare September 7, 2018 03:29

dotlambda reviewed Sep 11, 2018

View reviewed changes

FRidh merged commit 3155491 into NixOS:master Sep 18, 2018

CMCDragonkai deleted the bjoern branch September 19, 2018 01:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.bjoern: init at 2.2.2 #45557

pythonPackages.bjoern: init at 2.2.2 #45557

CMCDragonkai commented Aug 24, 2018

CMCDragonkai commented Aug 24, 2018

dotlambda commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

dotlambda commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

CMCDragonkai commented Sep 6, 2018

CMCDragonkai commented Sep 6, 2018

CMCDragonkai commented Sep 6, 2018

CMCDragonkai commented Sep 6, 2018

FRidh Sep 6, 2018

CMCDragonkai commented Sep 10, 2018

dotlambda Sep 11, 2018

jonashaag Sep 11, 2018

CMCDragonkai commented Sep 11, 2018 via email

CMCDragonkai commented Sep 17, 2018

pythonPackages.bjoern: init at 2.2.2 #45557

pythonPackages.bjoern: init at 2.2.2 #45557

Conversation

CMCDragonkai commented Aug 24, 2018

Motivation for this change

Things done

CMCDragonkai commented Aug 24, 2018

dotlambda commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

dotlambda commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

CMCDragonkai commented Sep 6, 2018

CMCDragonkai commented Sep 6, 2018

CMCDragonkai commented Sep 6, 2018

CMCDragonkai commented Sep 6, 2018

FRidh Sep 6, 2018

Choose a reason for hiding this comment

CMCDragonkai commented Sep 10, 2018

dotlambda Sep 11, 2018

Choose a reason for hiding this comment

jonashaag Sep 11, 2018

Choose a reason for hiding this comment

CMCDragonkai commented Sep 11, 2018 via email

CMCDragonkai commented Sep 17, 2018