Add a resource for GCE routes #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixops/resources/gce_route.py
Outdated
| self.copy_credentials(defn) | ||
|
|
||
| if check: | ||
| if self._check(): |
There was a problem hiding this comment.
doesn't seem like self._check() ever returns True right ?
Fix an issue with real_state_differ check, GCP API adds the region and the project name to the network so we need to remove those before checking if the network in the state match.
…tHop
Example:
```
{}:{
machine =
{ config, pkgs, resources, lib, ... }:
let
in
{
deployment.targetEnv = "gce";
....
};
ec2machine = {resources, lib, ...}:
{
deployment.targetEnv = "ec2";
...
};
resources.gceRoutes.lb-default = {resources, ...}:{
destination = resources.machines.ec2machine;
priority = 800;
nextHop = resources.machines.machine ;
tags = [ "workers" ] ;
};
}
```
Be aware that nextHop can only be a GCE machine, if not an exception
will be raised
| raise Exception("nextHop can only be a GCE machine.") | ||
| raise | ||
| except libcloud.common.google.ResourceNotFoundError: | ||
| raise Exception("The machine {0} isn't deployed, it need to be before it's added as nextHop".format(nextHop_name)) |
There was a problem hiding this comment.
Can we use create_after method instead ?
There was a problem hiding this comment.
I added create_after, but I'm keeping this in case we use --include the flag to only deploy the route. In that case the deployment the above exception will be raised.
nix/gce-routes.nix
Outdated
| }; | ||
|
|
||
| destination = mkOption { | ||
| example ="1.1.1.1/32"; |
There was a problem hiding this comment.
nitpick: add space afer =
nix/gce-routes.nix
Outdated
| example ="1.1.1.1/32"; | ||
| type = types.nullOr (types.either types.str (resource "machine")); | ||
| apply = x: if x == null || (builtins.isString x) then x else "res-" + x._name; | ||
| description = "The destination IP range that this route applies to. If the destination IP of a packet falls in this range, it matches this route."; |
There was a problem hiding this comment.
nitpick: can you use '' '' for long descriptions instead
description = ''
foo
''
If nextHop or destination is a machine, wait for them to be deployed before creating the route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of a route is