gnome3.gconf: re-add as a pointer to the removal PR #45571
Conversation
GrahamcOfBorg
added
6.topic: GNOME
pkgs/desktops/gnome-3/default.nix
Outdated
| @@ -399,6 +399,8 @@ lib.makeScope pkgs.newScope (self: with self; { | |||
|
|
|||
| gnome-packagekit = callPackage ./misc/gnome-packagekit { }; | |||
|
|
|||
| # TODO: remove this after 18.09 has forked off | |||
| gconf = throw "gconf has been removed because it’s a pile of trash, see https://github.com/NixOS/nixpkgs/pull/43268"; | |||
There was a problem hiding this comment.
Let's keep the error message for the end-user a bit... less opinionated :). I'm sure it is a piece of trash, but the message itself would be better suited as something like:
gconf has been removed, it is deprecated. See #43268 for more information.
Couldn't find a solid date for the deprecation. Would have been nice for the message (it is deprecated since 20xx), showing how much of a pile of rot it is.
Additionally, since we're linking to the PR, it may be interesting to review the main body of #43268, not to remove the opinions, but to make it more obvious for the end-user what is the way forward.
There was a problem hiding this comment.
I was not able to find a date either, thought the wiki page for the initiative appears to have been created in 2009: https://wiki.gnome.org/action/recall/Initiatives/GnomeGoals/GSettingsMigration?action=recall&rev=1
There was a problem hiding this comment.
I added tl;dr to the OP in the PR.
There was a problem hiding this comment.
I'm 👎 on the "pile of trash" note. We may have users who like gconf, or even authored gconf. Being so judgemental gains us nothing risks hurting the feelings of our users, or being extra-annoying when they have to change their system configuration to keep up with NixOS.
What would be useful here is a "what do I do now?" message about how to change their now-broken system in to a working-like-I-want system.
There was a problem hiding this comment.
Note, referring people to #43268 is not even especially helpful: it doesn't have any instructions about what the user should do, just that it is evidently feces. Yes it does ;)
There was a problem hiding this comment.
I did not really mean anything too bad by that, the fact is the majority of software is bad, including all of mine. Though I agree that the comment does not really add anything and some people might be offended by it so I will tone it down.
NixOS#43268 removed GConf from GNOME 3 package set, let’s add an error for a little while to save people digging through the commit log.
jtojnar
force-pushed
the
gconf-to-error
branch
from
8fc020d
to
9f0eb75
Compare
|
The error message was now addressed, I have one more concern though. As I wrote in the removal PR:
We might want to move it now, so the users that still use it do not have to fix that second time. Do you think that moving it to top-level is a good idea? Or should we create a new |
|
Bah, this breaks building |
Motivation for this change
#43268 removed GConf from GNOME 3 package set, let’s add an error for a little while to save people digging through the commit log.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)