Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packer: 1.2.4 -> 1.2.5 #45527

Merged
merged 1 commit into from Aug 24, 2018
Merged

packer: 1.2.4 -> 1.2.5 #45527

merged 1 commit into from Aug 24, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 24, 2018 •
edited

Motivation for this change

https://github.com/hashicorp/packer/blob/master/CHANGELOG.md#125-july-16-2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: packer

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cbn8wdbbb98chqyn9abhnn5vsdayn76q-packer-1.2.5-bin
shrinking /nix/store/cbn8wdbbb98chqyn9abhnn5vsdayn76q-packer-1.2.5-bin/bin/packer
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
stripping (with command /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip and flags -S) in /nix/store/cbn8wdbbb98chqyn9abhnn5vsdayn76q-packer-1.2.5-bin/bin
patching script interpreter paths in /nix/store/cbn8wdbbb98chqyn9abhnn5vsdayn76q-packer-1.2.5-bin
checking for references to /build in /nix/store/cbn8wdbbb98chqyn9abhnn5vsdayn76q-packer-1.2.5-bin...
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
/nix/store/cbn8wdbbb98chqyn9abhnn5vsdayn76q-packer-1.2.5-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: packer

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0glkdfl7sav009kavnx4czfz9hjb0glb-packer-1.2.5-bin
shrinking /nix/store/0glkdfl7sav009kavnx4czfz9hjb0glb-packer-1.2.5-bin/bin/packer
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/0glkdfl7sav009kavnx4czfz9hjb0glb-packer-1.2.5-bin/bin
patching script interpreter paths in /nix/store/0glkdfl7sav009kavnx4czfz9hjb0glb-packer-1.2.5-bin
checking for references to /build in /nix/store/0glkdfl7sav009kavnx4czfz9hjb0glb-packer-1.2.5-bin...
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
/nix/store/0glkdfl7sav009kavnx4czfz9hjb0glb-packer-1.2.5-bin

@xeji xeji merged commit c5f6d13 into NixOS:master Aug 24, 2018
@Ma27 Ma27 deleted the update-packer branch August 24, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @xeji