Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk10: add darwin support #45575

Merged
merged 1 commit into from Aug 25, 2018
Merged

openjdk10: add darwin support #45575

merged 1 commit into from Aug 25, 2018

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Aug 24, 2018 •
edited

Motivation for this change

Copied from the jdk8 derivation and adjusted for jdk10: https://github.com/NixOS/nixpkgs/blob/beaa0984c63f6e93a9ddfae18c70d39602e90cca/pkgs/development/compilers/openjdk/darwin/8.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

periklis
periklis reviewed Aug 24, 2018
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adisbladis
Copy link
Member

@GrahamcOfBorg bulid openjdk10

@adisbladis
Copy link
Member

@GrahamcOfBorg build openjdk10

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: openjdk10

Partial log (click to expand)

  inflating: ZuluJCEPolicies/DISCLAIMER
  inflating: ZuluJCEPolicies/local_policy.jar
  inflating: ZuluJCEPolicies/US_export_policy.jar
post-installation fixup
moving /nix/store/5milax90x403x9hk5w0xp1jy7j02p2xq-zulu10.1+11-jdk10/man to /nix/store/5milax90x403x9hk5w0xp1jy7j02p2xq-zulu10.1+11-jdk10/share/man
gzipping man pages under /nix/store/5milax90x403x9hk5w0xp1jy7j02p2xq-zulu10.1+11-jdk10/share/man/
strip is /nix/store/vvbmqsh5ikrxkiwj71dwfbzcwf4bfav8-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5milax90x403x9hk5w0xp1jy7j02p2xq-zulu10.1+11-jdk10/lib  /nix/store/5milax90x403x9hk5w0xp1jy7j02p2xq-zulu10.1+11-jdk10/bin
patching script interpreter paths in /nix/store/5milax90x403x9hk5w0xp1jy7j02p2xq-zulu10.1+11-jdk10
/nix/store/5milax90x403x9hk5w0xp1jy7j02p2xq-zulu10.1+11-jdk10

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openjdk10

Partial log (click to expand)

these paths will be fetched (193.74 MiB download, 457.05 MiB unpacked):
  /nix/store/55fm6f2cdikpydfxgfl7gpb93z46ndl9-openjdk-10.0.1-b10-jre
  /nix/store/a9kgdcfv8wv0rbwvsvg230b2cwjyxp5f-openjdk-10.0.1-b10
copying path '/nix/store/55fm6f2cdikpydfxgfl7gpb93z46ndl9-openjdk-10.0.1-b10-jre' from 'https://cache.nixos.org'...
copying path '/nix/store/a9kgdcfv8wv0rbwvsvg230b2cwjyxp5f-openjdk-10.0.1-b10' from 'https://cache.nixos.org'...
/nix/store/a9kgdcfv8wv0rbwvsvg230b2cwjyxp5f-openjdk-10.0.1-b10

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: openjdk10

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@adisbladis adisbladis merged commit 1b2cc51 into NixOS:master Aug 25, 2018
@adisbladis
Copy link
Member

adisbladis commented Aug 25, 2018 •
edited

Thank you! :)

@uri-canva uri-canva deleted the jdk-10-darwin branch October 15, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis left review comments

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@uri-canva @adisbladis @GrahamcOfBorg @matthewbauer @periklis