Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udftools: 1.0.0b3 -> 2.0 #45583

Merged
merged 1 commit into from Aug 27, 2018
Merged

udftools: 1.0.0b3 -> 2.0 #45583

merged 1 commit into from Aug 27, 2018

Conversation

dguibert
Copy link
Member

This path also migrates to the github repo.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: udftools

Partial log (click to expand)

shrinking /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/sbin/pktsetup
shrinking /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/sbin/mkudffs
shrinking /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/sbin/udflabel
gzipping man pages under /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/lib  /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/bin  /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/sbin
patching script interpreter paths in /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0
checking for references to /build in /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0...
moving /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/sbin/* to /nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0/bin
/nix/store/8jcvznyzmzmbk5mmr6s5ry9shyai0vsw-udftools-2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: udftools

Partial log (click to expand)

shrinking /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/sbin/udflabel
shrinking /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/sbin/pktsetup
shrinking /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/sbin/mkudffs
gzipping man pages under /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/lib  /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/bin  /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/sbin
patching script interpreter paths in /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0
checking for references to /build in /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0...
moving /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/sbin/* to /nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0/bin
/nix/store/f959l7xx7xvfsfiarhaag4fbcrivjpjz-udftools-2.0

@xeji
Copy link
Contributor

xeji commented Aug 25, 2018

The udev rule needs to be patched (/usr/sbin/...):

$ more ./lib/udev/rules.d/80-pktsetup.rules
# Create and remove packet writing device for each optical block device
ACTION=="add", SUBSYSTEM=="block", ENV{ID_CDROM}=="1", RUN+="/usr/sbin/pktsetup %E{MAJOR}:%E{MINOR}"
ACTION=="remove", SUBSYSTEM=="block", ENV{ID_CDROM}=="1", RUN+="/usr/sbin/pktsetup -d %E{MAJOR}:%E{MINOR}"

@dguibert
udftools: 1.0.0b3 -> 2.0
9859ed2 
This path also migrates to the github repo.
@dguibert
Copy link
Member Author

The udev rule has been fixed.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: udftools

Partial log (click to expand)

shrinking /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/bin/udfinfo
shrinking /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/sbin/pktsetup
shrinking /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/sbin/mkudffs
shrinking /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/sbin/udflabel
gzipping man pages under /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/lib  /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/bin  /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/sbin
patching script interpreter paths in /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0
checking for references to /build in /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0...
moving /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/sbin/* to /nix/store/7p3vnllg51azabvq5nv6xpfcwh297ysx-udftools-2.0/bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: udftools

Partial log (click to expand)

shrinking /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/sbin/udflabel
shrinking /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/sbin/pktsetup
shrinking /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/sbin/mkudffs
gzipping man pages under /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/lib  /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/bin  /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/sbin
patching script interpreter paths in /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0
checking for references to /build in /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0...
moving /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/sbin/* to /nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0/bin
/nix/store/z06v0mqg92xf8y0wh6srxy1f32k49dnf-udftools-2.0

@xeji xeji merged commit 2f6cc89 into NixOS:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dguibert @GrahamcOfBorg @xeji