Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/wordpress: fix test #45582

Merged
merged 1 commit into from Aug 24, 2018
Merged

nixos/tests/wordpress: fix test #45582

merged 1 commit into from Aug 24, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Aug 24, 2018

Motivation for this change

Test was broken on hydra.

  • explicitly add dbHost to fix test
  • while at it, remove unnecessary options that the wordpress module sets by default anyway
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@xeji
nixos/tests/wordpress: fix test
9383c47 
- explicitly add dbHost to fix test
- remove unnecessary options that are set by default anyway
@xeji
Copy link
Contributor Author

xeji commented Aug 24, 2018

@GrahamcOfBorg test wordpress

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.wordpress

Partial log (click to expand)

web: exit status 1
syncing
web: running command: sync
web: exit status 0
test script finished in 189.03s
cleaning up
killing web (pid 600)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/chz1a2a1b907cldxirqdf86yj8da0y9g-vm-test-run-wordpress

@xeji
Copy link
Contributor Author

xeji commented Aug 24, 2018

cc #40257

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.wordpress

Partial log (click to expand)

web: exit status 1
syncing
web: running command: sync
web: exit status 0
test script finished in 31.51s
cleaning up
killing web (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/pk5xmgyds4wby3sy92il2n79grxr8afr-vm-test-run-wordpress

@globin globin merged commit 672a0eb into NixOS:master Aug 24, 2018
@xeji xeji deleted the patch/wordpress-test branch August 24, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @globin