Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexget: 2.14.9 -> 2.14.18 #45568

Merged
merged 4 commits into from Aug 26, 2018
Merged

Flexget: 2.14.9 -> 2.14.18 #45568

merged 4 commits into from Aug 26, 2018

Conversation

sjau
Copy link

@sjau sjau commented Aug 24, 2018

Motivation for this change

Flexget: 2.14.9 -> 2.14.18

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Aug 24, 2018

Is the Plex update related to this?

@sjau
Copy link
Author

sjau commented Aug 24, 2018

no, they are seperate.

@srhb
Copy link
Contributor

srhb commented Aug 25, 2018

@sjau In case you didn't see my messages on IRC: Perhaps it would be easier to reopen this PR on a feature branch? I'm guessing that the wrong commits snuck in because this PR is from your master branch. :)

@dotlambda
Copy link
Member

See also #45594.

@Mic92 Mic92 merged commit 3d97ddc into NixOS:master Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjau @Mic92 @srhb @dotlambda @GrahamcOfBorg