Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.menhir: 20170712 -> 20180530 #45566

Closed
wants to merge 4 commits into from
Closed

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 24, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Aug 24, 2018

This update seems to break reason:

@GrahamcOfBorg build reason

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: reason

Partial log (click to expand)

Warning 3: deprecated: String.lowercase
Use String.lowercase_ascii instead.
    ocamlopt src/reason-parser/.reason.objs/reason_oprint.{cmx,o}
File "src/reason-parser/reason_oprint.ml", line 201, characters 27-42:
Warning 52: Code should not depend on the actual values of
this constructor's arguments. They are only for information
and may change in future versions. (See manual section 8.5)
make: *** [Makefile:8: build] Error 1
builder for '/nix/store/sfnysr64wfgz1bildgmvh4sjizhzwnq1-ocaml-reason-3.3.3.drv' failed with exit code 2
error: build of '/nix/store/sfnysr64wfgz1bildgmvh4sjizhzwnq1-ocaml-reason-3.3.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: reason

Partial log (click to expand)

Warning 3: deprecated: String.lowercase
Use String.lowercase_ascii instead.
    ocamlopt src/reason-parser/.reason.objs/reason_oprint.{cmx,o}
File "src/reason-parser/reason_oprint.ml", line 201, characters 27-42:
Warning 52: Code should not depend on the actual values of
this constructor's arguments. They are only for information
and may change in future versions. (See manual section 8.5)
make: *** [Makefile:8: build] Error 1
builder for '/nix/store/sx8y6yfyap9ns9izfhw0r9dqbd9775zb-ocaml-reason-3.3.3.drv' failed with exit code 2
error: build of '/nix/store/sx8y6yfyap9ns9izfhw0r9dqbd9775zb-ocaml-reason-3.3.3.drv' failed

@Mic92
Copy link
Member Author

Mic92 commented Aug 24, 2018

@GrahamcOfBorg build reason

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/refmt
shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/testOprint
shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/lib/ocaml/4.05.0/site-lib/reason/reason.cmxs
shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/lib/ocaml/4.05.0/site-lib/reason/easy_format/reason.easy_format.cmxs
shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/lib/ocaml/4.05.0/site-lib/rtop/rtop.cmxs
patching script interpreter paths in /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3
/nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/hc888iabya82y3axi99sr0a3bjnm8z7h-ocaml-4.05.0/bin/ocaml"
checking for references to /build in /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3...
/nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: reason

Partial log (click to expand)

Warning 58: no cmx file was found in path for module UTop, and its interface was not compiled with -opaque
installing
Processing file reason.install as reason.
Processing file rtop.install as rtop.
post-installation fixup
moving /nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3/doc to /nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3/share/doc
patching script interpreter paths in /nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3
/nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dmgydn3x7ayd7rpfdqw8nrw0z93w549d-bash-4.4-p23/bin/bash"
/nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/8s1c9yndhd58wl8j2z20n0wm2hwvsqfk-ocaml-4.05.0/bin/ocaml"
/nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: reason

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qgghdvr6c08w5kvnz5lvsz87zrx1l9s9-menhir-20180530/lib  /nix/store/qgghdvr6c08w5kvnz5lvsz87zrx1l9s9-menhir-20180530/bin
patching script interpreter paths in /nix/store/qgghdvr6c08w5kvnz5lvsz87zrx1l9s9-menhir-20180530
/nix/store/qgghdvr6c08w5kvnz5lvsz87zrx1l9s9-menhir-20180530/share/doc/menhir/demos/find-menhir.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/qgghdvr6c08w5kvnz5lvsz87zrx1l9s9-menhir-20180530/share/doc/menhir/demos/obsolete/ocamldep.wrapper: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/qvkhx7xlgvzfz8lgawaaaybyj0ngyhv5-ocaml-4.06.1/bin/ocaml"
checking for references to /build in /nix/store/qgghdvr6c08w5kvnz5lvsz87zrx1l9s9-menhir-20180530...
wrong ELF type
wrong ELF type
cannot build derivation '/nix/store/6xayia4m26mkf64fm10nw900plvq1vwb-ocaml-reason-3.3.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6xayia4m26mkf64fm10nw900plvq1vwb-ocaml-reason-3.3.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: reason

Partial log (click to expand)

make[3]: *** [../OCamlMakefile:792: byte-code-library] Error 2
make[3]: Leaving directory '/build/opam-1.2.2/src_ext'
make[2]: *** [../OCamlMakefile:1227: subproj_extlib] Error 2
make[2]: Leaving directory '/build/opam-1.2.2/src_ext'
make[1]: *** [Makefile:39: build] Error 2
make[1]: Leaving directory '/build/opam-1.2.2/src_ext'
make: *** [Makefile:29: lib-ext] Error 2
builder for '/nix/store/64jbf424i0rk6jfxr1bs7kwbk0n3mgl4-opam-1.2.2.drv' failed with exit code 2
cannot build derivation '/nix/store/jjqa1nibbycq8vhpnbs712v5fqb7718a-ocaml-reason-3.3.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jjqa1nibbycq8vhpnbs712v5fqb7718a-ocaml-reason-3.3.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: reason

Partial log (click to expand)

/nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/testOprint
shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/reactjs_jsx_ppx_v2
shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/refmt
shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/refmttype
shrinking /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/ocamlmerlin-reason
patching script interpreter paths in /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3
/nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/hc888iabya82y3axi99sr0a3bjnm8z7h-ocaml-4.05.0/bin/ocaml"
checking for references to /build in /nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3...
/nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: reason

Partial log (click to expand)

make[3]: *** [../OCamlMakefile:792: byte-code-library] Error 2
make[3]: Leaving directory '/build/opam-1.2.2/src_ext'
make[2]: *** [../OCamlMakefile:1227: subproj_extlib] Error 2
make[2]: Leaving directory '/build/opam-1.2.2/src_ext'
make[1]: *** [Makefile:39: build] Error 2
make[1]: Leaving directory '/build/opam-1.2.2/src_ext'
make: *** [Makefile:29: lib-ext] Error 2
builder for '/nix/store/64jbf424i0rk6jfxr1bs7kwbk0n3mgl4-opam-1.2.2.drv' failed with exit code 2
cannot build derivation '/nix/store/jjqa1nibbycq8vhpnbs712v5fqb7718a-ocaml-reason-3.3.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jjqa1nibbycq8vhpnbs712v5fqb7718a-ocaml-reason-3.3.3.drv' failed

@Mic92
Copy link
Member Author

Mic92 commented Aug 24, 2018

compcert and verasco are also broken.

@Mic92
Copy link
Member Author

Mic92 commented Aug 24, 2018

Is verasco even under active development? http://compcert.inria.fr/verasco/release/
No release since 2016-03-07

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: reason

The following builds were skipped because they don't evaluate on x86_64-darwin: compcert

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reason

The following builds were skipped because they don't evaluate on x86_64-linux: compcert

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: reason

The following builds were skipped because they don't evaluate on aarch64-linux: compcert

Partial log (click to expand)

make[3]: *** [../OCamlMakefile:792: byte-code-library] Error 2
make[3]: Leaving directory '/build/opam-1.2.2/src_ext'
make[2]: *** [../OCamlMakefile:1227: subproj_extlib] Error 2
make[2]: Leaving directory '/build/opam-1.2.2/src_ext'
make[1]: *** [Makefile:39: build] Error 2
make[1]: Leaving directory '/build/opam-1.2.2/src_ext'
make: *** [Makefile:29: lib-ext] Error 2
builder for '/nix/store/64jbf424i0rk6jfxr1bs7kwbk0n3mgl4-opam-1.2.2.drv' failed with exit code 2
cannot build derivation '/nix/store/jjqa1nibbycq8vhpnbs712v5fqb7718a-ocaml-reason-3.3.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jjqa1nibbycq8vhpnbs712v5fqb7718a-ocaml-reason-3.3.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reason

The following builds were skipped because they don't evaluate on x86_64-linux: compcert, verasco

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/m4q5cr4wx7yy0qls7ag1pq7m7idxxmg0-ocaml-reason-3.3.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: reason

The following builds were skipped because they don't evaluate on aarch64-linux: compcert, verasco

Partial log (click to expand)

make[3]: *** [../OCamlMakefile:792: byte-code-library] Error 2
make[3]: Leaving directory '/build/opam-1.2.2/src_ext'
make[2]: *** [../OCamlMakefile:1227: subproj_extlib] Error 2
make[2]: Leaving directory '/build/opam-1.2.2/src_ext'
make[1]: *** [Makefile:39: build] Error 2
make[1]: Leaving directory '/build/opam-1.2.2/src_ext'
make: *** [Makefile:29: lib-ext] Error 2
builder for '/nix/store/64jbf424i0rk6jfxr1bs7kwbk0n3mgl4-opam-1.2.2.drv' failed with exit code 2
cannot build derivation '/nix/store/jjqa1nibbycq8vhpnbs712v5fqb7718a-ocaml-reason-3.3.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jjqa1nibbycq8vhpnbs712v5fqb7718a-ocaml-reason-3.3.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: reason

The following builds were skipped because they don't evaluate on x86_64-darwin: compcert, verasco

Partial log (click to expand)

Warning 58: no cmx file was found in path for module UTop, and its interface was not compiled with -opaque
installing
Processing file reason.install as reason.
Processing file rtop.install as rtop.
post-installation fixup
moving /nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3/doc to /nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3/share/doc
patching script interpreter paths in /nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3
/nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dmgydn3x7ayd7rpfdqw8nrw0z93w549d-bash-4.4-p23/bin/bash"
/nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/8s1c9yndhd58wl8j2z20n0wm2hwvsqfk-ocaml-4.05.0/bin/ocaml"
/nix/store/cjdnhyxxinppx86rncklxifa108lll65-ocaml-reason-3.3.3

@Mic92
Copy link
Member Author

Mic92 commented Aug 24, 2018

@GrahamcOfBorg build compcert

@vbgl
Copy link
Contributor

vbgl commented Aug 24, 2018

What’s the motivation for this update? Can we avoid breaking things?

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: compcert

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: compcert

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: compcert

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@Mic92
Copy link
Member Author

Mic92 commented Aug 24, 2018

I want build my software against the latest version so I don't need to migrate later because of incompatibilities and I can report to upstream, if I find bugs. So far only verasco does not build. They seem to have no bug tracker or version control system. Do you know if upstream development is still active there?

@vbgl
Copy link
Contributor

vbgl commented Aug 31, 2018

Should we wait for a release of CompCert or is the chosen development version good enough?

Marking Verasco as broken seems OK; can you add a comment about requiring some specific menhir version? Thanks.

@Mic92
Copy link
Member Author

Mic92 commented Aug 31, 2018

cc @bschommer is the current master we choose stable enough to be included instead of the current HEAD?

@bschommer
Copy link

bschommer commented Sep 1, 2018

For the moment the current version of menhir is stable enough to build CompCert. There will be probably some changes in the near future when the issue described in AbsInt/CompCert#231 is fixed in the upstream version of menhir, but that could still take some time. Concerning verasco @jhjourdan probably knows more of its status.

@Mic92
Copy link
Member Author

Mic92 commented Sep 1, 2018

@bschommer I mean if the current master of CompCert is stable enough for nixpkgs. Because the latest release of CompCert does not compile with this version of menhir.

@bschommer
Copy link

bschommer commented Sep 1, 2018

Sorry for the misunderstanding, the Academic releases CompCert on Github are @xavierleroy responsibility, but I think the current master should be nearly stable enough, there will some changes in the next weeks.

@xavierleroy
Copy link

I am hoping to have a v3.4 public release of CompCert by the end of the month (sept 2018). I agree with @bschommer that the current Git master is in good shape and has no known major issues. Now it's up to the package maintainers to decide whether to base a package on unreleased code.

@jhjourdan
Copy link

The development of Verasco is currently in pause and there exists no recent release. Therefore, indeed, it is incompatible with recent versions of Menhir.

Perhaps the package maintainers could create a dependency from Verasco to the old version of Menhir ?

@Mic92 Mic92 closed this Oct 28, 2018
@Mic92 Mic92 deleted the menhir branch October 28, 2018 20:36
@Mic92
Copy link
Member Author

Mic92 commented Oct 28, 2018

Closed in favor of #49349

@Mic92
Copy link
Member Author

Mic92 commented Oct 28, 2018

I don't think we should have unmaintained projects like verasco in nixpkgs so.

@Mic92 Mic92 mentioned this pull request Oct 28, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants