Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/datadog-agent: Fix type of use_dogstatsd #45587

Merged
merged 1 commit into from Aug 24, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Aug 24, 2018

Motivation for this change

The "yes" in the configuration examples is only valid for yaml, where it's equivalent to a json bool. We're going directly to json, so we can't do that. With "yes" the dogstatsd server silently fails to bind.

CC @tazjin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@tazjin
Copy link
Member

tazjin commented Aug 24, 2018

Good catch, LGTM!

YAML really is a terrible format with all these weird, sharp edges (check the full list of strings that are parsed into booleans!) ...

@xeji xeji merged commit 8f61e96 into NixOS:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants