Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nftables: enable works in linux kernel 4.17 and 4.18 #45586

Merged
merged 1 commit into from Aug 25, 2018
Merged

nftables: enable works in linux kernel 4.17 and 4.18 #45586

merged 1 commit into from Aug 25, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Aug 24, 2018 •
edited

Motivation for this change

Enable works nftables in linux kernel 4.17 and 4.18
See #45483

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Aug 24, 2018

I wonder what change in the kernel caused this to be needed?

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 24, 2018

diff -Nuar kernel_4.14.txt kernel_4.17.txt | grep NF_TABLES

 CONFIG_NF_TABLES=m
-CONFIG_NF_TABLES_INET=m
-CONFIG_NF_TABLES_NETDEV=m
+# CONFIG_NF_TABLES_INET is not set
+# CONFIG_NF_TABLES_NETDEV is not set
-CONFIG_NF_TABLES_IPV4=m
-CONFIG_NF_TABLES_ARP=m
+# CONFIG_NF_TABLES_IPV4 is not set
+# CONFIG_NF_TABLES_ARP is not set
-CONFIG_NF_TABLES_IPV6=m
+# CONFIG_NF_TABLES_IPV6 is not set
-CONFIG_NF_TABLES_BRIDGE=m
+# CONFIG_NF_TABLES_BRIDGE is not set

Disabled NF_TABLES on kernel 4.17

@globin
Copy link
Member

globin commented Aug 24, 2018

https://cateee.net/lkddb/web-lkddb/NF_TABLES_INET.html shows that there were changes for 4.17

@dezgeg
Copy link
Contributor

dezgeg commented Aug 25, 2018

Yes, but what I was after is whether it was a deliberate change that these symbols are no longer buildable as modules, and not because say, Nixpkgs kernel config has something weird.

It appears that this is a deliberate upstream choice though: torvalds/linux@02c7b25

@dezgeg dezgeg merged commit 32c3cbd into NixOS:master Aug 25, 2018
@Izorkin Izorkin deleted the kernel-nftables branch August 26, 2018 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @dezgeg @globin @GrahamcOfBorg