mbrola: init at 3.0.1h #45580

bignaux · 2018-08-24T12:33:05Z

Motivation for this change

old abandonneware, but still relevant for good tts. Lot of stuff to make it works!

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

bignaux · 2018-08-24T13:54:14Z

@aske : since you are maintainer of espeak-ng, it could interesting you.
From eSpeak version 1.44 onwards, eSpeak calls the mbrola program directly, rather than passing phoneme data to it using a pipe 👍

$ espeak -v mb-fr1 "Hello world"
mbrola: mbrola: No such file or directory
mbrowrap error: write(): Broken pipe
Error: Could not load the specified mbrola voice file.

jtojnar · 2018-08-24T14:55:40Z

pkgs/applications/misc/mbrola/default.nix

+
+	buildInputs = [ unzip ];
+	nativeBuildInputs = [ patchelf makeWrapper gcc_multi ];
+	propagatedBuildInputs = [ bash ];


This will probably not do the thing you want. It basically adds bash to buildInputs of all packages that have mbrola in buildInputs.

jtojnar · 2018-08-24T15:00:50Z

pkgs/applications/misc/mbrola/default.nix

+{ stdenv, fetchurl, unzip, bash, patchelf, stdenv_32bit, makeWrapper, gcc_multi }:
+
+let
+	TCTS="https://tcts.fpms.ac.be/synthesis/mbrola";


Could you use coding style more consistent with the rest of nixpkgs? Namely:

Two space indentation (no tabs 😢)

A single space on each side of =

No trailing spaces

Files ending with single \n character: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

jtojnar · 2018-08-24T22:40:44Z

pkgs/applications/misc/mbrola/default.nix

+		--prefix LD_PRELOAD : "$out/lib/libstrongexit.so"
+
+		for voice in ??[0-9]; do
+		cp -a $voice $out/share/mbrola/voices


Is this a normal location? The espeak code suggests a different ones (though, it looks like there is no single standard).

i think it's the better we could do, if you've a better idea, tell me. I just need the PR merge to improve integration on navit gps navigation software. mbrola is really dead but we don't have many not too bad tts in foss.

Debian seems to install them to share/mbrola/$lang/$lang¹, which does not seem particularly elegant. I like the share/mbrola/voices/$lang but we should coordinate with espeak-ng, if they add --with-mbrola-voices-directory configure flag.

sorry, i don't understand why it's so important since we won't have /usr/share something hard coded like that. you choose i fix and we merge and i can continue the real stuff. no one since 2013 have took the time to make that available, that's not critical stuff we have to be very clear. That's not glibc 2.27 broken my locale and no one care about remove the bad derivation. that's an old dead project i'd like to have support for espeak because foss have no real good tts yet.

jtojnar · 2018-08-25T21:21:07Z

pkgs/applications/misc/mbrola/default.nix

+
+pname = "mbrola";
+name = "${pname}-${version}";
+version = "3.0.1h";


The version should be 3.01h according to the pattern used by the news page http://tcts.fpms.ac.be/synthesis/mbrola/mbrnews.html

hum i always look at gentoo ebuild https://gitweb.gentoo.org/repo/gentoo.git/tree/app-accessibility/mbrola/mbrola-3.0.1h-r6.ebuild?id=4a409a1ecd75d064e8b471f6131bb1feb83c37a8 . I will look and decide. I'm a bit tired to spend so much time on review and not advanced work.

jtojnar · 2018-08-25T21:22:05Z

pkgs/applications/misc/mbrola/default.nix

+	# debian provides manpage and libstrongexit.so
+	# read https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856331;msg=5
+	deb = fetchurl {
+		url = "http://http.debian.net/debian/pool/non-free/m/mbrola/mbrola_3.01h+2-3.debian.tar.xz";


The syntax is still not idiomatic. Try indenting with hnix.

ryantm

Address jtojnar's comments

stale · 2020-06-02T05:10:35Z

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the related code and @ mention them in a comment.
Ask on the NixOS Discourse.
Ask on the #nixos channel on irc.freenode.net.

SuperSandro2000

Please format this correct. You can use a formatter like nixfmt or view other derivations to know how.

SuperSandro2000 · 2020-11-28T04:57:49Z

pkgs/applications/misc/mbrola/default.nix

+
+pname = "mbrola";
+name = "${pname}-${version}";
+version = "3.0.1h";


Suggested change

pname = "mbrola";

name = "${pname}-${version}";

version = "3.0.1h";

pname = "mbrola";

version = "3.0.1h";

SuperSandro2000 · 2020-11-29T05:00:00Z

Replaced by #93401 because it inits at 3.3.

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Aug 24, 2018

mbrola: init at 3.0.1h

1f1c7c8

bignaux force-pushed the mbrola branch from 625421a to 1f1c7c8 Compare August 24, 2018 14:01

espeak: add mbrola support

e29e873

jtojnar reviewed Aug 24, 2018

View reviewed changes

remove useless propagatedBuildInputs

3eb25ec

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Aug 24, 2018

fix typo

260bb07

jtojnar reviewed Aug 24, 2018

View reviewed changes

jtojnar reviewed Aug 25, 2018

View reviewed changes

ryantm requested changes Mar 9, 2019

View reviewed changes

flokli added the 9.needs: reporter feedback label May 1, 2019

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020

symphorien mentioned this pull request Jul 18, 2020

mbrola: init at 3.3 #93401

Merged

10 tasks

SuperSandro2000 requested changes Nov 28, 2020

View reviewed changes

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 28, 2020

SuperSandro2000 marked this pull request as draft November 28, 2020 04:59

SuperSandro2000 closed this Nov 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mbrola: init at 3.0.1h #45580

mbrola: init at 3.0.1h #45580

bignaux commented Aug 24, 2018

bignaux commented Aug 24, 2018 •

edited

jtojnar Aug 24, 2018

jtojnar Aug 24, 2018

jtojnar Aug 24, 2018

bignaux Aug 25, 2018 •

edited

jtojnar Aug 25, 2018

bignaux Aug 25, 2018

jtojnar Aug 25, 2018

bignaux Aug 25, 2018

jtojnar Aug 25, 2018

ryantm left a comment

stale bot commented Jun 2, 2020

SuperSandro2000 left a comment

SuperSandro2000 Nov 28, 2020

SuperSandro2000 commented Nov 29, 2020

mbrola: init at 3.0.1h #45580

mbrola: init at 3.0.1h #45580

Conversation

bignaux commented Aug 24, 2018

Motivation for this change

Things done

bignaux commented Aug 24, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bignaux Aug 25, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryantm left a comment

Choose a reason for hiding this comment

stale bot commented Jun 2, 2020

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuperSandro2000 commented Nov 29, 2020

bignaux commented Aug 24, 2018 •

edited

bignaux Aug 25, 2018 •

edited