Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbd: 3.17 -> 3.18. Also, add which to buildInputs (needed by test pha… #45713

Closed
wants to merge 1 commit into from

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Aug 28, 2018

…se).

Motivation for this change

To update nbd to the latest version. While building, I noticed the test scripts complaining about the lack of which, so I added that too. I have briefly tested the client and server with two real hosts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@qolii
Copy link
Contributor Author

qolii commented Aug 28, 2018

Oof. Out of date. Ignore.

@qolii qolii closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants