Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bunny: init at 1.1 #45714

Merged
merged 2 commits into from Aug 28, 2018
Merged

bunny: init at 1.1 #45714

merged 2 commits into from Aug 28, 2018

Conversation

buffet
Copy link
Member

@buffet buffet commented Aug 28, 2018

Motivation for this change

Pretty useful not to have to think about what system you're on when
doing basic (un)installation tasks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

countingsort added 2 commits August 28, 2018 20:51
bunny: init at 1.1
6a67663 
Motivation for this change

Pretty useful not to have to think about what system you're on when
doing basic (un)installation tasks.
Fixed typo
1f21d9d
@xeji
Copy link
Contributor

xeji commented Aug 28, 2018

@GrahamcOfBorg build bunny

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bunny

Partial log (click to expand)

cp -r src/backend \
        "//nix/store/n87d3ck1z8if6xjv25ndsfqvgzwb9pkz-bunny-1.1/share/bunny/"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n87d3ck1z8if6xjv25ndsfqvgzwb9pkz-bunny-1.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n87d3ck1z8if6xjv25ndsfqvgzwb9pkz-bunny-1.1/bin
patching script interpreter paths in /nix/store/n87d3ck1z8if6xjv25ndsfqvgzwb9pkz-bunny-1.1
/nix/store/n87d3ck1z8if6xjv25ndsfqvgzwb9pkz-bunny-1.1/bin/bunny: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/n87d3ck1z8if6xjv25ndsfqvgzwb9pkz-bunny-1.1...
/nix/store/n87d3ck1z8if6xjv25ndsfqvgzwb9pkz-bunny-1.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bunny

Partial log (click to expand)

        "//nix/store/fpm3llv39rx9mmzlwkvknizk869vb3g8-bunny-1.1/bin/bunny"
mkdir -p "//nix/store/fpm3llv39rx9mmzlwkvknizk869vb3g8-bunny-1.1/share/bunny"
cp -r src/backend \
        "//nix/store/fpm3llv39rx9mmzlwkvknizk869vb3g8-bunny-1.1/share/bunny/"
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fpm3llv39rx9mmzlwkvknizk869vb3g8-bunny-1.1/bin
patching script interpreter paths in /nix/store/fpm3llv39rx9mmzlwkvknizk869vb3g8-bunny-1.1
/nix/store/fpm3llv39rx9mmzlwkvknizk869vb3g8-bunny-1.1/bin/bunny: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/fpm3llv39rx9mmzlwkvknizk869vb3g8-bunny-1.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bunny

Partial log (click to expand)

cp -r src/backend \
        "//nix/store/h57vldccm3swqv6kxxhfdfidrjqikn0f-bunny-1.1/share/bunny/"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h57vldccm3swqv6kxxhfdfidrjqikn0f-bunny-1.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h57vldccm3swqv6kxxhfdfidrjqikn0f-bunny-1.1/bin
patching script interpreter paths in /nix/store/h57vldccm3swqv6kxxhfdfidrjqikn0f-bunny-1.1
/nix/store/h57vldccm3swqv6kxxhfdfidrjqikn0f-bunny-1.1/bin/bunny: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/h57vldccm3swqv6kxxhfdfidrjqikn0f-bunny-1.1...
/nix/store/h57vldccm3swqv6kxxhfdfidrjqikn0f-bunny-1.1

xeji
xeji approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

@xeji xeji merged commit 42bfaab into NixOS:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@buffet @xeji @GrahamcOfBorg @Janik-Haag