Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwm-git: init at 20180602 #45716

Merged
merged 1 commit into from Aug 29, 2018
Merged

dwm-git: init at 20180602 #45716

merged 1 commit into from Aug 29, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Aug 28, 2018

Motivation for this change

The latest tagged release dwm 6.1 is from 2015. Newer patches/add-ons target the development version from git, which sucks even less 馃槃

Also add an option to override the entire config file instead of generating a patch for it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dwm-git

Partial log (click to expand)

chmod 644 /nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602/share/man/man1/dwm.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602
shrinking /nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602/bin/dwm
gzipping man pages under /nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602/bin
patching script interpreter paths in /nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602
checking for references to /build in /nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602...
/nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dwm-git

Partial log (click to expand)

chmod 755 /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/bin/dwm
mkdir -p /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/share/man/man1
sed "s/VERSION/6.1/g" < dwm.1 > /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/share/man/man1/dwm.1
chmod 644 /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/share/man/man1/dwm.1
post-installation fixup
gzipping man pages under /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/bin
patching script interpreter paths in /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602
/nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dwm-git

Partial log (click to expand)

chmod 644 /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602/share/man/man1/dwm.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602
shrinking /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602/bin/dwm
gzipping man pages under /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602/bin
patching script interpreter paths in /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602
checking for references to /build in /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602...
/nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602

Mic92
Mic92 reviewed Aug 28, 2018
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -15941,6 +15941,10 @@ with pkgs;
patches = config.dwm.patches or [];
};

dwm-git = callPackage ../applications/window-managers/dwm/git.nix {
patches = config.dwm.patches or [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add?

conf = config.dwm.conf or [];

There might a program called conf in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done.

@xeji
dwm-git: init at 20180602
1b0263d 
The latest tagged release dwm 6.1 is from 2015, so
the development version is much more current.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dwm-git

Partial log (click to expand)

chmod 644 /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602/share/man/man1/dwm.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602
shrinking /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602/bin/dwm
gzipping man pages under /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602/bin
patching script interpreter paths in /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602
checking for references to /build in /nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602...
/nix/store/d1scq7xph55cvkghhc3qwry9v97xhv3z-dwm-git-20180602

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dwm-git

Partial log (click to expand)

/nix/store/89ix5m2mbgywswimgggnfs42smj01d14-dwm-git-20180602

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dwm-git

Partial log (click to expand)

chmod 755 /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/bin/dwm
mkdir -p /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/share/man/man1
sed "s/VERSION/6.1/g" < dwm.1 > /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/share/man/man1/dwm.1
chmod 644 /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/share/man/man1/dwm.1
post-installation fixup
gzipping man pages under /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602/bin
patching script interpreter paths in /nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602
/nix/store/c1cgx008xdwd24bim0ch0pj95kh6waqw-dwm-git-20180602

@xeji xeji merged commit 683707e into NixOS:master Aug 29, 2018
@xeji xeji deleted the p/dwm-git branch August 29, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @Mic92