Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyowm: fix python3 build #46549

Merged
merged 1 commit into from Sep 11, 2018
Merged

python3Packages.pyowm: fix python3 build #46549

merged 1 commit into from Sep 11, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 11, 2018 •
edited

Motivation for this change

See https://hydra.nixos.org/build/80714323

Version 2.9 requires geojson==2.x'. To allow 2.4, the constraint required some patching using substituteInPlace'.

Addresses #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
python3Packages.pyowm: fix python3 build
55703cc 
See https://hydra.nixos.org/build/80714323

Version 2.9 requires `geojson==2.x'. To allow 2.4, the constraint
required some patching using `substituteInPlace'.

Addresses NixOS#45960
@Ma27 Ma27 requested a review from FRidh as a code owner September 11, 2018 21:51
@xeji
Copy link
Contributor

xeji commented Sep 11, 2018

@GrahamcOfBorg build python36Packages.pyowm python27Packages.pyowm

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.pyowm, python27Packages.pyowm

Partial log (click to expand)

Successfully installed pyowm-2.9.0
/build/pyowm-2.9.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c56wb0n0q4w42m5bw07iza205yrmvmxa-python3.6-pyowm-2.9.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c56wb0n0q4w42m5bw07iza205yrmvmxa-python3.6-pyowm-2.9.0/lib
patching script interpreter paths in /nix/store/c56wb0n0q4w42m5bw07iza205yrmvmxa-python3.6-pyowm-2.9.0
checking for references to /build in /nix/store/c56wb0n0q4w42m5bw07iza205yrmvmxa-python3.6-pyowm-2.9.0...
/nix/store/c56wb0n0q4w42m5bw07iza205yrmvmxa-python3.6-pyowm-2.9.0
/nix/store/j1k9ckf9zh4f4qp0qwmpghaf382iz64x-python2.7-pyowm-2.9.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.pyowm, python27Packages.pyowm

Partial log (click to expand)

Successfully installed pyowm-2.9.0
/build/pyowm-2.9.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hrlrjyz9lk5d2gl48idbmyv2p8gary1a-python3.6-pyowm-2.9.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hrlrjyz9lk5d2gl48idbmyv2p8gary1a-python3.6-pyowm-2.9.0/lib
patching script interpreter paths in /nix/store/hrlrjyz9lk5d2gl48idbmyv2p8gary1a-python3.6-pyowm-2.9.0
checking for references to /build in /nix/store/hrlrjyz9lk5d2gl48idbmyv2p8gary1a-python3.6-pyowm-2.9.0...
/nix/store/hrlrjyz9lk5d2gl48idbmyv2p8gary1a-python3.6-pyowm-2.9.0
/nix/store/9y8lpc298scvvzlc7f2xzp8nwp6wbarm-python2.7-pyowm-2.9.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.pyowm, python27Packages.pyowm

Partial log (click to expand)

post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/pxwfp7ix06fxkl0210nk33c8wyk35lpy-python2.7-pyowm-2.9.0/lib
Successfully installed pyowm-2.9.0
patching script interpreter paths in /nix/store/pxwfp7ix06fxkl0210nk33c8wyk35lpy-python2.7-pyowm-2.9.0
/private/tmp/nix-build-python3.6-pyowm-2.9.0.drv-0/pyowm-2.9.0
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/hznwl1pn676z5k0w8dhaa905gjsl2m4q-python3.6-pyowm-2.9.0/lib
patching script interpreter paths in /nix/store/hznwl1pn676z5k0w8dhaa905gjsl2m4q-python3.6-pyowm-2.9.0

@xeji xeji merged commit a25dcb6 into NixOS:master Sep 11, 2018
xeji pushed a commit that referenced this pull request Sep 11, 2018
@Ma27 @xeji
python3Packages.pyowm: fix python3 build (#46549)
f95ddad 
See https://hydra.nixos.org/build/80714323

Version 2.9 requires `geojson==2.x'. To allow 2.4, the constraint
required some patching using `substituteInPlace'.

Addresses #45960

(cherry picked from commit a25dcb6)
@xeji
Copy link
Contributor

xeji commented Sep 11, 2018

backported: f95ddad

@Ma27 Ma27 deleted the fix-pyowm branch September 12, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @xeji @GrahamcOfBorg