Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdsh: set default module to ssh, remove obsolete fixes #46528

Merged
merged 1 commit into from Sep 29, 2018
Merged

pdsh: set default module to ssh, remove obsolete fixes #46528

merged 1 commit into from Sep 29, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Having rsh the default connection mechanism seems outdated (and unsafe).

CC @peti for review and testing

Things done
  • Set default remote module to ssh
  • Remove -lgcc_s hack (seems not needed anymore?).
  • Remove pam dependency, is not recognized by configure
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pdsh

Partial log (click to expand)

shrinking /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33/lib/pdsh/sshcmd.so
shrinking /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33/lib/pdsh/machines.so
shrinking /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33/lib/pdsh/execcmd.so
shrinking /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33/lib/pdsh/dshgroup.so
gzipping man pages under /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33/lib  /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33/bin
patching script interpreter paths in /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33
/nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33/bin/dshbak: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/q9ajsngf2w3r10dg7b1148wzq1avp4gj-perl-5.28.0/bin/perl -w"
checking for references to /build in /nix/store/adf3mbwf244s9lp5lx0n6xakvbhnkm2g-pdsh-2.33...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pdsh

Partial log (click to expand)

shrinking /nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33/lib/pdsh/sshcmd.so
shrinking /nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33/lib/pdsh/xcpucmd.so
shrinking /nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33/lib/pdsh/xrcmd.so
gzipping man pages under /nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33/lib  /nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33/bin
patching script interpreter paths in /nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33
/nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33/bin/dshbak: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/p3cg3qswdvq6vdjigs83did8km5dlqk7-perl-5.28.0/bin/perl -w"
checking for references to /build in /nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33...
/nix/store/qkqs6hfby9015cxzp4lllg99vqndmzi7-pdsh-2.33

@matthewbauer matthewbauer merged commit a87c16b into NixOS:master Sep 29, 2018
@markuskowa markuskowa deleted the pdsh-fix branch September 29, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @GrahamcOfBorg @matthewbauer