openssl: 1.1.0 -> 1.1.1 #46524

alyssais · 2018-09-11T14:08:18Z

Motivation for this change

From https://www.openssl.org/blog/blog/2018/09/11/release111/:

OpenSSL 1.1.1 is API and ABI compliant with OpenSSL 1.1.0 so most applications that work with 1.1.0 can gain many of the benefits of TLSv1.3 simply by dropping in the new OpenSSL version.

Added openssl_1_0 and openssl_1_1 aliases because that's the level of granularity packages almost certainly want, and will make future upgrades like this much easier.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

timokau · 2018-09-11T14:42:22Z

If it is "API and ABI compliant with 1.1.0", why do we need the aliases? Are there actual cases where 1.1.1 causes a failure?

alyssais · 2018-09-11T14:47:35Z

Not that I know of, but didn't want to break a convention by removing the 1_0_2 alias.

timokau · 2018-09-11T14:53:30Z

Oh I just noticed that you actually did remove the 1_1_0 version, I missed that at first.

The commit message is a bit confusing though. You don't actually update openssl, you just update the dependency for a few versions right? Or am I misreading that?

alyssais · 2018-09-11T14:56:08Z

I updated OpenSSL from 1.1.0 to 1.1.1. However, nixpkgs.openssl is the 1.0 channel. Both channels are simultaneously packaged by nixpkgs. So, I updated the 1.1 channel from 1.1.0 to 1.1.1.

pkgs/development/libraries/openssl/default.nix

timokau · 2018-09-11T14:59:08Z

LGTM assuming there are no build failures

@GrahamcOfBorg build ldns nodejs-10_x tor

GrahamcOfBorg · 2018-09-11T14:59:24Z

Failure on x86_64-linux (full log)

Attempted: ldns, nodejs-10_x, tor

Partial log (click to expand)

Operating system: x86_64-whatever-linux2
./config: eval: line 1: /usr/bin/env: not found
building
build flags: -j2 -l2 SHELL=/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash MANDIR=\$\(man\)/share/man
make: *** No targets specified and no makefile found.  Stop.
builder for '/nix/store/r4da46wj7zk26vwwwfnc4gvp0n9axbx3-openssl-1.1.1.drv' failed with exit code 2
cannot build derivation '/nix/store/pqx6x1asb5qp6if2nipny8nmd0jlxdid-ldns-1.7.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3h5q2czc35bzyvnri5m9zybcq5j4kdpx-nodejs-10.9.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gzr81b0xzrvmmsdq8lsgvdv7zjq39ibk-tor-0.3.4.8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/3h5q2czc35bzyvnri5m9zybcq5j4kdpx-nodejs-10.9.0.drv', '/nix/store/gzr81b0xzrvmmsdq8lsgvdv7zjq39ibk-tor-0.3.4.8.drv', '/nix/store/pqx6x1asb5qp6if2nipny8nmd0jlxdid-ldns-1.7.0.drv' failed

GrahamcOfBorg · 2018-09-11T15:00:16Z

Failure on aarch64-linux (full log)

Attempted: ldns, nodejs-10_x, tor

Partial log (click to expand)

Operating system: aarch64-whatever-linux2
./config: eval: line 1: /usr/bin/env: not found
building
build flags: -j96 -l96 SHELL=/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash MANDIR=\$\(man\)/share/man
make: *** No targets specified and no makefile found.  Stop.
builder for '/nix/store/7cvf108rbgxkkd6bdzjwmy78f8vh96ck-openssl-1.1.1.drv' failed with exit code 2
cannot build derivation '/nix/store/kpn2xhwlm1kz547li1zmy5n407nd9hhm-ldns-1.7.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7kdb95yjkfkbf7axwdxf0xgywj54gp0q-nodejs-10.9.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/scpjwfzmyqjcdhky3w2xsalbq9ni3ksg-tor-0.3.4.8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/7kdb95yjkfkbf7axwdxf0xgywj54gp0q-nodejs-10.9.0.drv', '/nix/store/kpn2xhwlm1kz547li1zmy5n407nd9hhm-ldns-1.7.0.drv', '/nix/store/scpjwfzmyqjcdhky3w2xsalbq9ni3ksg-tor-0.3.4.8.drv' failed

GrahamcOfBorg · 2018-09-11T15:34:19Z

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nodejs-10_x

The following builds were skipped because they don't evaluate on x86_64-darwin: ldns, tor

Partial log (click to expand)

  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/b069mlwx07cm18p53y69p4asr2i81dym-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/serializer-common.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/serializer-common.o ../deps/v8/src/snapshot/serializer-common.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/b069mlwx07cm18p53y69p4asr2i81dym-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/serializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/serializer.o ../deps/v8/src/snapshot/serializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/b069mlwx07cm18p53y69p4asr2i81dym-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/snapshot-common.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/snapshot-common.o ../deps/v8/src/snapshot/snapshot-common.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/b069mlwx07cm18p53y69p4asr2i81dym-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/snapshot-source-sink.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/snapshot-source-sink.o ../deps/v8/src/snapshot/snapshot-source-sink.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/b069mlwx07cm18p53y69p4asr2i81dym-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/startup-deserializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/startup-deserializer.o ../deps/v8/src/snapshot/startup-deserializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/b069mlwx07cm18p53y69p4asr2i81dym-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/startup-serializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/startup-serializer.o ../deps/v8/src/snapshot/startup-serializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/b069mlwx07cm18p53y69p4asr2i81dym-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/source-position-table.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/source-position-table.o ../deps/v8/src/source-position-table.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/b069mlwx07cm18p53y69p4asr2i81dym-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/source-position.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/source-position.o ../deps/v8/src/source-position.cc
building of '/nix/store/biy5xczq4bcpzyg5pxx1y09rqchm52cc-nodejs-10.9.0.drv' timed out after 1800 seconds
error: build of '/nix/store/biy5xczq4bcpzyg5pxx1y09rqchm52cc-nodejs-10.9.0.drv' failed

orivej · 2018-09-11T15:56:26Z

pkgs/top-level/all-packages.nix

@@ -11454,7 +11456,7 @@ with pkgs;
      };
    })
    openssl_1_0_2
-    openssl_1_1_0;
+    openssl_1_1_1;


I think we should not introduce openssl_1_1_1 attribute, we should rename openssl_1_1_0 to openssl_1_1 and use that.

Same with openssl_1_0?

No, it does not have to be changed in this PR, and it may be left as is: AFAIK openssl_1_0_1 and openssl_1_0_2 were incompatible.

Please don't introduce openssl_1_0 alias for openssl_1_0_2 yet.

Yes, please use openssl_1_1 and openssl_1_0_2.

I don't feel strongly either way, but if future 1.1.x versions are expected to break backwards compatibility to 1.1.1, having that version explicitly makes sense to me.

orivej · 2018-09-11T17:20:16Z

pkgs/tools/misc/powerline-rs/default.nix

@@ -1,4 +1,4 @@
-{ stdenv, lib, rustPlatform, fetchFromGitHub, pkgconfig, file, perl, curl, cmake, openssl_1_1_0, libssh2, libgit2, libzip, Security }:
+{ stdenv, lib, rustPlatform, fetchFromGitHub, pkgconfig, file, perl, curl, cmake, openssl_1_1, libssh2, libgit2, libzip, Security }:


Could you use openssl here, and call powerline-rs with openssl = openssl_1_1 in all-packages.nix?

globin · 2018-09-11T17:30:18Z

Other than the change to openssl_1_1 I think it's good to go since nixpkgs does not generally use this yet and that would be a large and complex change, for which I will hopefully have time after the release.

timokau · 2018-09-11T18:48:14Z

The ofBorg failure is probably unrelated. It would be nice to still fix them in a separate commit though. They look like sandbox issues (/usr/bin/env is impure and not available in a sandbox) that should be fixable with a simple patchShebangs or substituteInPlace.

orivej · 2018-09-11T20:41:17Z

pkgs/tools/misc/powerline-rs/default.nix

@@ -15,7 +15,7 @@ rustPlatform.buildRustPackage rec {
  cargoSha256 = "184s432a6damzvl0lv6jar1iml9dq60r190aqjy44lcg938981zc";

  nativeBuildInputs = [ pkgconfig file perl cmake curl ];
-  buildInputs = [ openssl_1_1_0 libssh2 libgit2 libzip ] ++ lib.optional stdenv.isDarwin Security;
+  buildInputs = [ openssl_1_1 libssh2 libgit2 libzip ] ++ lib.optional stdenv.isDarwin Security;


Please replace this with openssl too.

Oops. Fixed.

fpletz · 2018-09-12T19:01:09Z

@GrahamcOfBorg build ldns nodejs-10_x tor powerline-rs

GrahamcOfBorg · 2018-09-12T19:18:43Z

Failure on aarch64-linux (full log)

Attempted: ldns, nodejs-10_x, tor, powerline-rs

Partial log (click to expand)

installing /nix/store/mxczbbwrkp1sgk4hhbhp8n9mkjb3rm6b-nodejs-10.9.0/lib/node_modules/npm/node_modules/normalize-package-data/lib/make_warning.js
installing /nix/store/mxczbbwrkp1sgk4hhbhp8n9mkjb3rm6b-nodejs-10.9.0/lib/node_modules/npm/node_modules/normalize-package-data/lib/fixer.js
installing /nix/store/mxczbbwrkp1sgk4hhbhp8n9mkjb3rm6b-nodejs-10.9.0/lib/node_modules/npm/node_modules/normalize-package-data/lib/extract_description.js
installing /nix/store/mxczbbwrkp1sgk4hhbhp8n9mkjb3rm6b-nodejs-10.9.0/lib/node_modules/npm/node_modules/nopt/README.md
installing /nix/store/mxczbbwrkp1sgk4hhbhp8n9mkjb3rm6b-nodejs-10.9.0/lib/node_modules/npm/node_modules/nopt/package.json
installing /nix/store/mxczbbwrkp1sgk4hhbhp8n9mkjb3rm6b-nodejs-10.9.0/lib/node_modules/npm/node_modules/nopt/LICENSE
installing /nix/store/mxczbbwrkp1sgk4hhbhp8n9mkjb3rm6b-nodejs-10.9.0/lib/node_modules/npm/node_modules/nopt/CHANGELOG.md
installing /nix/store/mxczbbwrkp1sgk4hhbhp8n9mkjb3rm6b-nodejs-10.9.0/lib/node_modules/npm/node_modules/nopt/.travis.ym
builder for '/nix/store/iidhwkyf0zgi8iy1xg2r8v0nf15m8bkf-nodejs-10.9.0.drv' failed with exit code 2
error: build of '/nix/store/iidhwkyf0zgi8iy1xg2r8v0nf15m8bkf-nodejs-10.9.0.drv' failed

GrahamcOfBorg · 2018-09-12T19:21:21Z

Failure on x86_64-linux (full log)

Attempted: ldns, nodejs-10_x, tor, powerline-rs

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8/bin
patching script interpreter paths in /nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8
/nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8/bin/torify: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/w0csdvqxswvbwn8mp6ajs0h3r3xk9xz9-tor-0.3.4.8-geoip
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w0csdvqxswvbwn8mp6ajs0h3r3xk9xz9-tor-0.3.4.8-geoip
checking for references to /build in /nix/store/w0csdvqxswvbwn8mp6ajs0h3r3xk9xz9-tor-0.3.4.8-geoip...
error: build of '/nix/store/dgilcdiprs124kwwm6vgxkb1ylwg70vm-nodejs-10.9.0.drv' failed

GrahamcOfBorg · 2018-09-12T19:36:43Z

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nodejs-10_x, powerline-rs

The following builds were skipped because they don't evaluate on x86_64-darwin: ldns, tor

Partial log (click to expand)

  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/gpw7q363dmc5nxp8asl9rbgblk4gfmyw-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/builtin-serializer-allocator.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/builtin-serializer-allocator.o ../deps/v8/src/snapshot/builtin-serializer-allocator.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/gpw7q363dmc5nxp8asl9rbgblk4gfmyw-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/builtin-serializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/builtin-serializer.o ../deps/v8/src/snapshot/builtin-serializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/gpw7q363dmc5nxp8asl9rbgblk4gfmyw-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/builtin-snapshot-utils.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/builtin-snapshot-utils.o ../deps/v8/src/snapshot/builtin-snapshot-utils.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/gpw7q363dmc5nxp8asl9rbgblk4gfmyw-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/code-serializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/code-serializer.o ../deps/v8/src/snapshot/code-serializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/gpw7q363dmc5nxp8asl9rbgblk4gfmyw-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/default-deserializer-allocator.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/default-deserializer-allocator.o ../deps/v8/src/snapshot/default-deserializer-allocator.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/gpw7q363dmc5nxp8asl9rbgblk4gfmyw-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/default-serializer-allocator.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/default-serializer-allocator.o ../deps/v8/src/snapshot/default-serializer-allocator.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/gpw7q363dmc5nxp8asl9rbgblk4gfmyw-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/deserializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/deserializer.o ../deps/v8/src/snapshot/deserializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.14"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj/gen -I/nix/store/j54sy9zx13nmkcbic1g1dyhha4h1nnwl-zlib-1.2.11-dev/include -I/nix/store/1gadgxvbf1xdiffs9p9fz8xvb8hwx7ia-libuv-1.21.0/include -I/nix/store/gpw7q363dmc5nxp8asl9rbgblk4gfmyw-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/natives-common.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.9.0.drv-0/node-v10.9.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/natives-common.o ../deps/v8/src/snapshot/natives-common.cc
building of '/nix/store/5xca4i0p623s0nhvsqnc8g0d6m0m2v7q-nodejs-10.9.0.drv' timed out after 1800 seconds
error: build of '/nix/store/5xca4i0p623s0nhvsqnc8g0d6m0m2v7q-nodejs-10.9.0.drv' failed

fpletz · 2018-09-12T19:39:24Z

nodejs-10_x builds locally for me. Seems to be a timeout issue but doesn't make much sense according to the log.

@grahamc Is there a timeout per package?

timokau · 2018-09-12T19:53:06Z

No, the timeout is per build including all dependencies.

fpletz · 2018-09-12T20:12:28Z

Then the question is how following error can be possible (from the x86_64-linux log):

installing /nix/store/dvs7h6kgb3qrg9dxjvq93fzqbng5sjbd-nodejs-10.9.0/lib/node_modules/npm/node_modules/tweetnacl/CHANGELOG.md
installing /nix/store/dvs7h6kgb3qrg9dxjvq93fzqbng5sjbd-nodejs-10.9.0/lib/node_modules/npm/node_modules/tweetnacl/PULL_REQUEST_TEMPLATE.md
installing /nix/store/dvs7h6kgb3qrg9dxjvq93fzqbng5sjbd-nodejs-10.9.0/lib/node_modules/npm/node_modules/tweetnacl/AUTHORS.md
installing /nix/store/dvs7h6kgb3qrg9dxjvq93fzqbng5sjbd-nodejs-10.9.0/lib/node_modules/npm/node_modules/tweetnacl/README.md
installing /nix/store/dvs7h6kgb3qrg9dxjvq93fzqbng5s
builder for '/nix/store/dgilcdiprs124kwwm6vgxkb1ylwg70vm-nodejs-10.9.0.drv' failed with exit code 2
building '/nix/store/3z707vqg4k2biwlljdy070xpbdf21si0-powerline-rs-0.1.8.drv'...
unpacking sources
unpacking source archive /nix/store/bvklx0kpx3giaqcvbrb2r7i9mk6h4z6k-source
source root is source

timokau · 2018-09-12T21:21:03Z

Hm that seems odd for a timeout.
@GrahamcOfBorg build tor

GrahamcOfBorg · 2018-09-12T21:21:19Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-12T21:21:36Z

Success on aarch64-linux (full log)

Attempted: tor

Partial log (click to expand)

/nix/store/haq9nsci5srsrf0vagywfb9jsx9lxfr3-tor-0.3.4.8

GrahamcOfBorg · 2018-09-12T21:29:44Z

Success on x86_64-linux (full log)

Attempted: tor

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8/bin
patching script interpreter paths in /nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8
/nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8/bin/torify: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/w0csdvqxswvbwn8mp6ajs0h3r3xk9xz9-tor-0.3.4.8-geoip
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w0csdvqxswvbwn8mp6ajs0h3r3xk9xz9-tor-0.3.4.8-geoip
checking for references to /build in /nix/store/w0csdvqxswvbwn8mp6ajs0h3r3xk9xz9-tor-0.3.4.8-geoip...
/nix/store/8i1893wiw5gp778qgg03d3mqy3zah15h-tor-0.3.4.8

orivej · 2018-09-12T21:42:27Z

@GrahamcOfBorg build openssl_1_1

GrahamcOfBorg · 2018-09-12T21:42:58Z

Success on aarch64-linux (full log)

Attempted: openssl_1_1

Partial log (click to expand)

/nix/store/al9bhp78cmwx3nyfym30k5a8w5fx34mp-openssl-1.1.1-bin

GrahamcOfBorg · 2018-09-12T21:42:59Z

Success on x86_64-darwin (full log)

Attempted: openssl_1_1

Partial log (click to expand)

/nix/store/7wq9rshkg2j3mc9fy1pn7jcg7q19kydn-openssl-1.1.1-bin

GrahamcOfBorg · 2018-09-12T21:43:01Z

Success on x86_64-linux (full log)

Attempted: openssl_1_1

Partial log (click to expand)

/nix/store/ynvzqq6w622jlj2mdgh7r2qrq0315s4s-openssl-1.1.1-bin

openssl: 1.1.0 -> 1.1.1

8fb5157

GrahamcOfBorg added 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Sep 11, 2018

alyssais commented Sep 11, 2018

View reviewed changes

pkgs/development/libraries/openssl/default.nix Outdated Show resolved Hide resolved

timokau approved these changes Sep 11, 2018

View reviewed changes

orivej suggested changes Sep 11, 2018

View reviewed changes

openssl: choose names openssl_1_0_2, openssl_1_1

2a1e927

orivej reviewed Sep 11, 2018

View reviewed changes

powerline-rs: specify openssl version in override

9cef3ee

alyssais force-pushed the openssl_1_1_1 branch from 88c72be to 9cef3ee Compare September 12, 2018 09:22

openssl: fix 1.1.1 build with sandboxing enabled

9dac726

orivej approved these changes Sep 12, 2018

View reviewed changes

timokau approved these changes Sep 12, 2018

View reviewed changes

orivej-nixos merged commit 1ec301d into NixOS:master Sep 12, 2018

alyssais deleted the openssl_1_1_1 branch September 13, 2018 13:09

alyssais mentioned this pull request Oct 18, 2018

postgresql_11: init at 11.0 #48664

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openssl: 1.1.0 -> 1.1.1 #46524

openssl: 1.1.0 -> 1.1.1 #46524

alyssais commented Sep 11, 2018 •

edited by fpletz

timokau commented Sep 11, 2018

alyssais commented Sep 11, 2018

timokau commented Sep 11, 2018

alyssais commented Sep 11, 2018

timokau commented Sep 11, 2018

GrahamcOfBorg commented Sep 11, 2018

GrahamcOfBorg commented Sep 11, 2018

GrahamcOfBorg commented Sep 11, 2018

orivej Sep 11, 2018

alyssais Sep 11, 2018

orivej Sep 11, 2018

orivej Sep 11, 2018

globin Sep 11, 2018

timokau Sep 11, 2018

orivej Sep 11, 2018

globin commented Sep 11, 2018

timokau commented Sep 11, 2018

orivej Sep 11, 2018

alyssais Sep 12, 2018

fpletz commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

fpletz commented Sep 12, 2018

timokau commented Sep 12, 2018

fpletz commented Sep 12, 2018 •

edited

timokau commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

orivej commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

		@@ -1,4 +1,4 @@
		{ stdenv, lib, rustPlatform, fetchFromGitHub, pkgconfig, file, perl, curl, cmake, openssl_1_1_0, libssh2, libgit2, libzip, Security }:
		{ stdenv, lib, rustPlatform, fetchFromGitHub, pkgconfig, file, perl, curl, cmake, openssl_1_1, libssh2, libgit2, libzip, Security }:

openssl: 1.1.0 -> 1.1.1 #46524

openssl: 1.1.0 -> 1.1.1 #46524

Conversation

alyssais commented Sep 11, 2018 • edited by fpletz

Motivation for this change

Things done

timokau commented Sep 11, 2018

alyssais commented Sep 11, 2018

timokau commented Sep 11, 2018

alyssais commented Sep 11, 2018

timokau commented Sep 11, 2018

GrahamcOfBorg commented Sep 11, 2018

GrahamcOfBorg commented Sep 11, 2018

GrahamcOfBorg commented Sep 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

globin commented Sep 11, 2018

timokau commented Sep 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fpletz commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

fpletz commented Sep 12, 2018

timokau commented Sep 12, 2018

fpletz commented Sep 12, 2018 • edited

timokau commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

orivej commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

GrahamcOfBorg commented Sep 12, 2018

alyssais commented Sep 11, 2018 •

edited by fpletz

fpletz commented Sep 12, 2018 •

edited