Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart: 1.24.3 -> 2.0.0 #46533

Merged
merged 3 commits into from Sep 30, 2018
Merged

dart: 1.24.3 -> 2.0.0 #46533

merged 3 commits into from Sep 30, 2018

Conversation

bitmappergit
Copy link
Contributor

@bitmappergit bitmappergit commented Sep 11, 2018 •
edited

Motivation for this change

Dart SDK version was outdated, updated to newest stable version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bitmappergit
dart: 1.24.3 -> 2.0.0
4a014c5 
Updated Dart SDK links to 2.0.0.
@bitmappergit
dart: 1.24.3 -> 2.0.0
e495c87 
Updated Dart SDK link to 2.0.0.
@bitmappergit
dart: 1.24.3 -> 2.0.0
6d6053e 
Updated Dart SDK versions in all-packages.nix. Added missing double quote.
@bitmappergit
Copy link
Contributor Author

I've tested this expression on my system, it functions perfectly.

@xeji xeji mentioned this pull request Sep 30, 2018
Closed
9 tasks
@xeji
Copy link
Contributor

xeji commented Sep 30, 2018

@GrahamcOfBorg build dart_stable dart_old

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dart_stable, dart_old

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dart_stable, dart_old

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dart_stable, dart_old

Partial log (click to expand)

/nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0/bin/dartdevk: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0/bin/dartdevc: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0/bin/dartanalyzer: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0/bin/pub: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0/lib/analysis_server/tool/spec/generate_files: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0/lib/analyzer/tool/generate_files: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0/lib/front_end/tool/fasta: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0...
/nix/store/vfdx2dk1z2y76i2f6frwmmac9a6dg0sg-dart-2.0.0
/nix/store/5vpkly9ld3rijij8k67w1sgvyl18vq73-dart-1.24.3

@xeji xeji merged commit c126510 into NixOS:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bitmappergit @xeji @GrahamcOfBorg