Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sickgear: init at 0.17.5 #46538

Closed
wants to merge 1 commit into from
Closed

sickgear: init at 0.17.5 #46538

wants to merge 1 commit into from

Conversation

rembo10
Copy link
Contributor

@rembo10 rembo10 commented Sep 11, 2018 •
edited

Motivation for this change

Added sickgear package and nixos module. I can add myself as a maintainer on the next version bump and once #46514 is merged

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

@rembo10 Would it be possible to rename this to sickrage and add a package option like mysql has? The user could then choose between sickrage or sickgear and we could forget adding 2 services (see #46340).

@sterfield What do you think?

@rembo10
Copy link
Contributor Author

rembo10 commented Sep 13, 2018

Yeah, I think I'm alright with that. Or maybe create a sickbeard package, with the 3 as options? I know sickbeard hasn't been updated in a while but I think some people might still use it, and it's probably the most well known of the 3?

@aanderse
Copy link
Member

@rembo10 Calling the module sickbeard if that is the original software makes sense to me. The biggest thing is just to add the package option so we only need 1 service instead of 2 or 3 identical services.

@rembo10 rembo10 mentioned this pull request Sep 13, 2018
Merged
9 tasks
@rembo10
Copy link
Contributor Author

rembo10 commented Sep 13, 2018

Closing this in favor of #46607

@rembo10 rembo10 closed this Sep 13, 2018
@rembo10 rembo10 deleted the sickgear branch September 13, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rembo10 @aanderse @GrahamcOfBorg