Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git2r: add SSH support #46547

Merged
merged 1 commit into from Sep 18, 2018
Merged

git2r: add SSH support #46547

merged 1 commit into from Sep 18, 2018

Conversation

ivanbrennan
Copy link
Member

Add libssh2.dev as a native build input to the git2r R module.

Motivation for this change

When building the devtools R module, which depends on git2r, it reports that libssh2 cannot be found, and falls back to building without SSH support. Adding libssh2.dev to git2r's native build inputs fixes this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ivanbrennan
git2r: add SSH support
989f24b 
When building the devtools R module, which depends on git2r, it reports
that libssh2 cannot be found, and falls back to building without SSH
support. Adding libssh2.dev to git2r's native build inputs fixes this.
@Mic92
Copy link
Member

Mic92 commented Sep 12, 2018

@GrahamcOfBorg build rPackages.git2r

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rPackages.git2r

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rPackages.git2r

Partial log (click to expand)

** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded
* DONE (git2r)
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/wjjzxlgnbxy5c74pqkd91728v115van5-r-git2r-0.21.0
/nix/store/wjjzxlgnbxy5c74pqkd91728v115van5-r-git2r-0.21.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rPackages.git2r

Partial log (click to expand)

** building package indices
** testing if installed package can be loaded
* DONE (git2r)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7i8zi96y65v46cchi23vkvf6zsmz953i-r-git2r-0.21.0
shrinking /nix/store/7i8zi96y65v46cchi23vkvf6zsmz953i-r-git2r-0.21.0/library/git2r/libs/git2r.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/7i8zi96y65v46cchi23vkvf6zsmz953i-r-git2r-0.21.0
checking for references to /build in /nix/store/7i8zi96y65v46cchi23vkvf6zsmz953i-r-git2r-0.21.0...
/nix/store/7i8zi96y65v46cchi23vkvf6zsmz953i-r-git2r-0.21.0

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2018

It is weird that packages that are commonly found in buildInputs are in packagesWithNativeBuildInputs and packages that are in nativeBuildInputs goes to packagesWithBuildInputs. cc @knedlsepp @peti
@mnacamura Was this mixed up for R or is there a simple explanation?

@knedlsepp
Copy link
Member

@Mic92 I don't have any explanation, but it looks very much like a mixup.

@Mic92 Mic92 merged commit 947ae71 into NixOS:master Sep 18, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 18, 2018

Let's make this a separate issue.

@Mic92 Mic92 mentioned this pull request Sep 18, 2018
Open
@ivanbrennan ivanbrennan deleted the r-devtools branch September 18, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivanbrennan @Mic92 @GrahamcOfBorg @knedlsepp