Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pants: fix build #46545

Merged
merged 1 commit into from Sep 11, 2018
Merged

pants: fix build #46545

merged 1 commit into from Sep 11, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 11, 2018 •
edited

Motivation for this change

See https://hydra.nixos.org/build/80727495

pants' works with requests==2.19 to build successfully and nixpkgs' currently uses requests==2.19.1.
Patching the version constraint in `setup.py' accordingly fixes the problem.

Addresses #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
pants: fix build
2732641 
See https://hydra.nixos.org/build/80727495

`pants' works with requests==2.19 to build successfully and `nixpkgs' currently uses `requests==2.19.1`.
Patching the version constraint in `setup.py' accordingly fixes the problem.

Addresses NixOS#45960
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pants

Partial log (click to expand)

writing entry points to src/pantsbuild.pants.egg-info/entry_points.txt
reading manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pants

Partial log (click to expand)

reading manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/zj936xz0p8r34cdkfr9sf4yc74wr9hdz-pantsbuild.pants-1.7.0

@xeji
Copy link
Contributor

xeji commented Sep 11, 2018

@GrahamcOfBorg build python36Packages.pants

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.pants

Partial log (click to expand)

/nix/store/lyz849q6zvws27j75nbc8bgcwvvbc75z-pantsbuild.pants-1.7.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.pants

Partial log (click to expand)

/nix/store/zj936xz0p8r34cdkfr9sf4yc74wr9hdz-pantsbuild.pants-1.7.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.pants

Partial log (click to expand)

writing entry points to src/pantsbuild.pants.egg-info/entry_points.txt
reading manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

@xeji
Copy link
Contributor

xeji commented Sep 11, 2018

Thanks for fighting python dependency hell 😄

@xeji xeji merged commit 46d1166 into NixOS:master Sep 11, 2018
xeji pushed a commit that referenced this pull request Sep 11, 2018
@Ma27 @xeji
pants: fix build (#46545)
f097202 
See https://hydra.nixos.org/build/80727495

`pants' works with requests==2.19 to build successfully and `nixpkgs' currently uses `requests==2.19.1`.
Patching the version constraint in `setup.py' accordingly fixes the problem.

Addresses #45960

(cherry picked from commit 46d1166)
@xeji
Copy link
Contributor

xeji commented Sep 11, 2018

backported: f097202

@Ma27 Ma27 deleted the fix-python-pants branch September 11, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @xeji