Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria2: fix darwin build #46548

Merged
merged 1 commit into from Sep 11, 2018
Merged

aria2: fix darwin build #46548

merged 1 commit into from Sep 11, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 11, 2018

Not released yet, see aria2/aria2#1198

/cc ZHF #45961

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aria2

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qwjfacsrwcqil0yrfcnjj0bwg74xpl27-aria2-1.34.0
shrinking /nix/store/qwjfacsrwcqil0yrfcnjj0bwg74xpl27-aria2-1.34.0/bin/aria2c
gzipping man pages under /nix/store/qwjfacsrwcqil0yrfcnjj0bwg74xpl27-aria2-1.34.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qwjfacsrwcqil0yrfcnjj0bwg74xpl27-aria2-1.34.0/bin
patching script interpreter paths in /nix/store/qwjfacsrwcqil0yrfcnjj0bwg74xpl27-aria2-1.34.0
checking for references to /build in /nix/store/qwjfacsrwcqil0yrfcnjj0bwg74xpl27-aria2-1.34.0...
/nix/store/qwjfacsrwcqil0yrfcnjj0bwg74xpl27-aria2-1.34.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: aria2

Partial log (click to expand)

 /nix/store/zkfqg7icazgz0kj7rff6zdfbcf3v79sa-coreutils-8.29/bin/mkdir -p '/nix/store/0i1vx6mcm0db6gm8rz7jiq6fzq2vawwr-aria2-1.34.0/share/doc/aria2'
 /nix/store/zkfqg7icazgz0kj7rff6zdfbcf3v79sa-coreutils-8.29/bin/install -c -m 644 README README.rst README.html '/nix/store/0i1vx6mcm0db6gm8rz7jiq6fzq2vawwr-aria2-1.34.0/share/doc/aria2'
make[2]: Leaving directory '/private/tmp/nix-build-aria2-1.34.0.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-aria2-1.34.0.drv-0/source'
post-installation fixup
/nix/store/0i1vx6mcm0db6gm8rz7jiq6fzq2vawwr-aria2-1.34.0
gzipping man pages under /nix/store/0i1vx6mcm0db6gm8rz7jiq6fzq2vawwr-aria2-1.34.0/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0i1vx6mcm0db6gm8rz7jiq6fzq2vawwr-aria2-1.34.0/bin
patching script interpreter paths in /nix/store/0i1vx6mcm0db6gm8rz7jiq6fzq2vawwr-aria2-1.34.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aria2

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m3p7r3nchrjb8f2jxc93lizxcji4f19i-aria2-1.34.0
shrinking /nix/store/m3p7r3nchrjb8f2jxc93lizxcji4f19i-aria2-1.34.0/bin/aria2c
gzipping man pages under /nix/store/m3p7r3nchrjb8f2jxc93lizxcji4f19i-aria2-1.34.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m3p7r3nchrjb8f2jxc93lizxcji4f19i-aria2-1.34.0/bin
patching script interpreter paths in /nix/store/m3p7r3nchrjb8f2jxc93lizxcji4f19i-aria2-1.34.0
checking for references to /build in /nix/store/m3p7r3nchrjb8f2jxc93lizxcji4f19i-aria2-1.34.0...
/nix/store/m3p7r3nchrjb8f2jxc93lizxcji4f19i-aria2-1.34.0

@xeji xeji merged commit 2164e39 into NixOS:master Sep 11, 2018
@LnL7 LnL7 deleted the darwin-aria2 branch September 11, 2018 22:12
xeji pushed a commit that referenced this pull request Sep 11, 2018
@LnL7 @xeji
aria2: fix darwin build (#46548)
40e4aee 
Not released yet, see aria2/aria2#1198

/cc ZHF #45961

(cherry picked from commit 2164e39)
@xeji
Copy link
Contributor

xeji commented Sep 11, 2018

backported: 40e4aee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @xeji