Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] RFC #33 #46530

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[WIP] RFC #33 #46530

wants to merge 6 commits into from

Conversation

oxij
Copy link
Member

@oxij oxij commented Sep 11, 2018

See NixOS/rfcs#33, ignore the first two patches.

@oxij oxij mentioned this pull request Sep 11, 2018
Closed
@oxij
For example, run
921f309 
nix-instantiate --eval --strict -E 'with ((import ./lib).extend(self: super: { config = { configVersion = "16.03"; traceLevel = 0; }; })); showVal 1'
nix-instantiate --eval --strict -E 'with ((import ./lib).extend(self: super: { config = { configVersion = "16.03"; }; })); showVal 1
nix-instantiate --eval --strict -E 'with ((import ./lib).extend(self: super: { config = { configVersion = "17.03"; }; })); showVal 1
nix-instantiate --eval --strict -E 'with ((import ./lib).extend(self: super: { config = { configVersion = "18.03"; }; })); showVal 1
@Profpatsch
Copy link
Member

Tangential: I’d leave the stuff in debug.nix and make debug.nix depend on logging.nix. Debug statements should usually not stay in the code once it’s commited.

@oxij oxij changed the title RFC #33 [WIP] RFC #33 Oct 19, 2018
@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

Are there any updates on this pull request, please?

@Profpatsch
Copy link
Member

@oxij Do you intend to finish this WIP?

@oxij
Copy link
Member Author

oxij commented Aug 27, 2019 via email

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@Profpatsch
Copy link
Member

@oxij still the case?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 9, 2020
@oxij
Copy link
Member Author

oxij commented Jun 11, 2020 via email

@ryantm ryantm marked this pull request as draft October 23, 2020 03:11
@stale
Copy link

stale bot commented Apr 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@nbp nbp Awaiting requested review from nbp

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@infinisil infinisil Awaiting requested review from infinisil infinisil will be requested when the pull request is marked ready for review infinisil is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: work-in-progress 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@oxij @Profpatsch @mmahut @ryantm @GrahamcOfBorg @infinisil