Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.batteries: 2.8.0 -> 2.9.0 #46532

Merged
merged 2 commits into from Sep 17, 2018
Merged

ocamlPackages.batteries: 2.8.0 -> 2.9.0 #46532

merged 2 commits into from Sep 17, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 11, 2018

Motivation for this change

Compatibility with OCaml 4.07

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 12, 2018

@GrahamcOfBorg build fstar satysfi

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: fstar, satysfi

Partial log (click to expand)

cd ../../ucontrib && find . -type f -exec install -m 644 -D {} /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0/share/fstar/contrib/{} \;
# Then the tutorial
cd ../../doc/tutorial && find . -type f -exec install -m 644 -D {} /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0/share/fstar/tutorial/{} \;
make: Leaving directory '/private/tmp/nix-build-fstar-0.9.6.0.drv-0/source/src/ocaml-output'
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0/lib  /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0/bin
patching script interpreter paths in /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0
/nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0
/nix/store/15877n3d0v7bqzw17j8d4p1sfspd1bq2-satysfi-2018-03-07

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fstar, satysfi

Partial log (click to expand)

install -m 644 lib-satysfi/dist/packages/* /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07/share/satysfi/dist/packages
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07
shrinking /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07/bin/satysfi
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07/bin
patching script interpreter paths in /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07
checking for references to /build in /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07...
/nix/store/zshwd541f4vgz72fxzn99q19lfixnzrz-fstar-0.9.6.0
/nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: fstar, satysfi

Partial log (click to expand)


src/batBool.ml:111:  of_float (1. /. 0.) = false
///////////////////////////////////////////////////////////////////////////////
Ran: 1759 tests in: 36.71 seconds.
FAILURE
make: *** [Makefile:217: qtest-byte] Error 1
builder for '/nix/store/vc5kbzmin6m35gsfk44gw5if7i7scnx0-ocaml4.06.1-batteries-2.9.0.drv' failed with exit code 2
cannot build derivation '/nix/store/n95j4mr46fm6vb6zfsws4y67y1jixnr4-fstar-0.9.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rr6aa2b68ydilfjmd4wq4jq9zdxfzhvr-satysfi-2018-03-07.drv': 1 dependencies couldn't be built
error: build of '/nix/store/n95j4mr46fm6vb6zfsws4y67y1jixnr4-fstar-0.9.6.0.drv', '/nix/store/rr6aa2b68ydilfjmd4wq4jq9zdxfzhvr-satysfi-2018-03-07.drv' failed

@vbgl
Copy link
Contributor Author

vbgl commented Sep 13, 2018

@GrahamcOfBorg build fstar satysfi

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fstar, satysfi

Partial log (click to expand)

install -m 644 lib-satysfi/dist/packages/* /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07/share/satysfi/dist/packages
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07
shrinking /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07/bin/satysfi
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07/bin
patching script interpreter paths in /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07
checking for references to /build in /nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07...
/nix/store/zshwd541f4vgz72fxzn99q19lfixnzrz-fstar-0.9.6.0
/nix/store/lwlnj4ls6gs4f898bpkp9jaqmq79pag3-satysfi-2018-03-07

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: fstar, satysfi

Partial log (click to expand)

cd ../../ucontrib && find . -type f -exec install -m 644 -D {} /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0/share/fstar/contrib/{} \;
# Then the tutorial
cd ../../doc/tutorial && find . -type f -exec install -m 644 -D {} /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0/share/fstar/tutorial/{} \;
make: Leaving directory '/private/tmp/nix-build-fstar-0.9.6.0.drv-0/source/src/ocaml-output'
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0/lib  /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0/bin
patching script interpreter paths in /nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0
/nix/store/fqk7h1a5l1sh4y4ryxc4122g57af42cl-fstar-0.9.6.0
/nix/store/15877n3d0v7bqzw17j8d4p1sfspd1bq2-satysfi-2018-03-07

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fstar, satysfi

Partial log (click to expand)

make: Leaving directory '/build/source/src/ocaml-output'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/60hfqg9z2dffb8x0xgvfnhaw948lgmah-fstar-0.9.6.0
shrinking /nix/store/60hfqg9z2dffb8x0xgvfnhaw948lgmah-fstar-0.9.6.0/bin/.fstar.exe-wrapped
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/60hfqg9z2dffb8x0xgvfnhaw948lgmah-fstar-0.9.6.0/lib  /nix/store/60hfqg9z2dffb8x0xgvfnhaw948lgmah-fstar-0.9.6.0/bin
patching script interpreter paths in /nix/store/60hfqg9z2dffb8x0xgvfnhaw948lgmah-fstar-0.9.6.0
checking for references to /build in /nix/store/60hfqg9z2dffb8x0xgvfnhaw948lgmah-fstar-0.9.6.0...
/nix/store/60hfqg9z2dffb8x0xgvfnhaw948lgmah-fstar-0.9.6.0
/nix/store/9n6n0mh1gvg2gyaabw7l5hkgpjkbj7wy-satysfi-2018-03-07

@xeji xeji merged commit 19996db into NixOS:master Sep 17, 2018
@vbgl vbgl deleted the ocaml-batteries-2.9.0 branch September 17, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @xeji