Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-play-music-desktop-player: 4.5.0 -> 4.6.1 #45612

Merged
merged 1 commit into from Aug 25, 2018
Merged

google-play-music-desktop-player: 4.5.0 -> 4.6.1 #45612

merged 1 commit into from Aug 25, 2018

Conversation

baracoder
Copy link
Contributor

Motivation for this change

The new version has support for youtube music

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Aug 25, 2018

@GrahamcOfBorg build google-play-music-desktop-player

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: google-play-music-desktop-player

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: google-play-music-desktop-player

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z0plcmj797i2djb4d538y7xi64hnp2wn-google-play-music-desktop-player-4.6.1
shrinking /nix/store/z0plcmj797i2djb4d538y7xi64hnp2wn-google-play-music-desktop-player-4.6.1/share/google-play-music-desktop-player/libffmpeg.so
shrinking /nix/store/z0plcmj797i2djb4d538y7xi64hnp2wn-google-play-music-desktop-player-4.6.1/share/google-play-music-desktop-player/libnode.so
shrinking /nix/store/z0plcmj797i2djb4d538y7xi64hnp2wn-google-play-music-desktop-player-4.6.1/share/google-play-music-desktop-player/Google Play Music Desktop Player
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z0plcmj797i2djb4d538y7xi64hnp2wn-google-play-music-desktop-player-4.6.1/bin
patching script interpreter paths in /nix/store/z0plcmj797i2djb4d538y7xi64hnp2wn-google-play-music-desktop-player-4.6.1
checking for references to /build in /nix/store/z0plcmj797i2djb4d538y7xi64hnp2wn-google-play-music-desktop-player-4.6.1...
/nix/store/z0plcmj797i2djb4d538y7xi64hnp2wn-google-play-music-desktop-player-4.6.1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: google-play-music-desktop-player

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@srhb srhb merged commit fe51f56 into NixOS:master Aug 25, 2018
@baracoder baracoder deleted the update-gpmdp branch August 25, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baracoder @srhb @GrahamcOfBorg