Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skype 8.28 #45625

Merged
merged 1 commit into from Aug 26, 2018
Merged

Skype 8.28 #45625

merged 1 commit into from Aug 26, 2018

Conversation

emmanuelrosa
Copy link
Contributor

Motivation for this change

This change upgrades Skype from 8.24.0.2 to 8.28.0.41

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • [ ] macOS
    • other Linux distributions (Xubuntu)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after). The previous version is 646,569,504 and the new one 651,700,248 for a difference of 5,130,744.
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Aug 25, 2018

Please rebase instead of merging.

@emmanuelrosa
Copy link
Contributor Author

Rebase complete.

@FRidh
Copy link
Member

FRidh commented Aug 26, 2018

cc maintainers @PanAeon @jraygauthier

@FRidh FRidh merged commit 07ea150 into NixOS:master Aug 26, 2018
@emmanuelrosa emmanuelrosa deleted the skype-8.28 branch August 29, 2018 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants