extract_url: init at 1.6.2 #45624

alyssais · 2018-08-25T13:27:49Z

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

srhb · 2018-08-25T14:07:42Z

GrahamcOfBorg · 2018-08-25T14:08:06Z

Failure on x86_64-linux (full log)

Attempted: extract_url

Partial log (click to expand)

install flags: SHELL=/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash prefix=\$\(out\) install
/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash: ./extract_url.pl: /usr/bin/env: bad interpreter: No such file or directory
perl -cw extract_url.pl
extract_url.pl syntax OK
# target: install-bin - Install programs
/usr/bin/install -m 755 -d /nix/store/sciqkzmnwplk93gfkxcd6hbbqgs7ib10-extract_url-1.6.2/bin
/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash: /usr/bin/install: No such file or directory
make: *** [Makefile:149: install-bin] Error 127
builder for '/nix/store/86a3gny2v3s60arna2gw6sd0g5f0qjqj-extract_url-1.6.2.drv' failed with exit code 2
error: build of '/nix/store/86a3gny2v3s60arna2gw6sd0g5f0qjqj-extract_url-1.6.2.drv' failed

GrahamcOfBorg · 2018-08-25T14:08:25Z

Success on x86_64-darwin (full log)

Attempted: extract_url

Partial log (click to expand)

# install-man
/usr/bin/install -m 755 -d /nix/store/3rbbblj36p2irk5zdavia8zpz5wkxq9v-extract_url-1.6.2/share/man/man1
/usr/bin/install -m 644 *.1 /nix/store/3rbbblj36p2irk5zdavia8zpz5wkxq9v-extract_url-1.6.2/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/3rbbblj36p2irk5zdavia8zpz5wkxq9v-extract_url-1.6.2/share/man/
strip is /nix/store/vvbmqsh5ikrxkiwj71dwfbzcwf4bfav8-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/3rbbblj36p2irk5zdavia8zpz5wkxq9v-extract_url-1.6.2/bin
patching script interpreter paths in /nix/store/3rbbblj36p2irk5zdavia8zpz5wkxq9v-extract_url-1.6.2
/nix/store/3rbbblj36p2irk5zdavia8zpz5wkxq9v-extract_url-1.6.2/bin/extract_url: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/23hk7xnx502nxl8p9j7jsb3f7mhmywmd-perl-5.28.0/bin/perl"
/nix/store/3rbbblj36p2irk5zdavia8zpz5wkxq9v-extract_url-1.6.2

srhb · 2018-08-25T14:09:38Z

Looks like there's a few path patches needed. :)

GrahamcOfBorg · 2018-08-25T14:12:10Z

Failure on aarch64-linux (full log)

Attempted: extract_url

Partial log (click to expand)

install flags: SHELL=/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash prefix=\$\(out\) install
/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash: ./extract_url.pl: /usr/bin/env: bad interpreter: No such file or directory
perl -cw extract_url.pl
extract_url.pl syntax OK
# target: install-bin - Install programs
/usr/bin/install -m 755 -d /nix/store/palsb9a8l3yhz1n1bamwv46gy6pw7akh-extract_url-1.6.2/bin
/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash: /usr/bin/install: No such file or directory
make: *** [Makefile:149: install-bin] Error 127
builder for '/nix/store/qb95smp18fjpbl43jjmn8g4ch1nkbdlr-extract_url-1.6.2.drv' failed with exit code 2
error: build of '/nix/store/qb95smp18fjpbl43jjmn8g4ch1nkbdlr-extract_url-1.6.2.drv' failed

srhb · 2018-08-25T14:17:06Z

Maybe something like:

  preInstall = ''
    substituteInPlace Makefile --replace "/usr/bin/install" install
  '';

alyssais · 2018-08-25T14:57:41Z

Fixed! And tested with the sandbox on this time.

srhb · 2018-08-25T14:58:07Z

@GrahamcOfBorg build extract_url

GrahamcOfBorg · 2018-08-25T14:58:19Z

Success on x86_64-linux (full log)

Attempted: extract_url

Partial log (click to expand)

install -m 644 *.1 /nix/store/gmyfb49lcjwkjxl8wf02mrwh86wx1a72-extract_url-1.6.2/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gmyfb49lcjwkjxl8wf02mrwh86wx1a72-extract_url-1.6.2
gzipping man pages under /nix/store/gmyfb49lcjwkjxl8wf02mrwh86wx1a72-extract_url-1.6.2/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gmyfb49lcjwkjxl8wf02mrwh86wx1a72-extract_url-1.6.2/bin
patching script interpreter paths in /nix/store/gmyfb49lcjwkjxl8wf02mrwh86wx1a72-extract_url-1.6.2
/nix/store/gmyfb49lcjwkjxl8wf02mrwh86wx1a72-extract_url-1.6.2/bin/extract_url: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/q9ajsngf2w3r10dg7b1148wzq1avp4gj-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/gmyfb49lcjwkjxl8wf02mrwh86wx1a72-extract_url-1.6.2...
/nix/store/gmyfb49lcjwkjxl8wf02mrwh86wx1a72-extract_url-1.6.2

GrahamcOfBorg · 2018-08-25T14:58:51Z

Success on x86_64-darwin (full log)

Attempted: extract_url

Partial log (click to expand)

# install-man
install -m 755 -d /nix/store/2llyfxfhx6nmkxpwaygmpr6p4bj0mi81-extract_url-1.6.2/share/man/man1
install -m 644 *.1 /nix/store/2llyfxfhx6nmkxpwaygmpr6p4bj0mi81-extract_url-1.6.2/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/2llyfxfhx6nmkxpwaygmpr6p4bj0mi81-extract_url-1.6.2/share/man/
strip is /nix/store/vvbmqsh5ikrxkiwj71dwfbzcwf4bfav8-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2llyfxfhx6nmkxpwaygmpr6p4bj0mi81-extract_url-1.6.2/bin
patching script interpreter paths in /nix/store/2llyfxfhx6nmkxpwaygmpr6p4bj0mi81-extract_url-1.6.2
/nix/store/2llyfxfhx6nmkxpwaygmpr6p4bj0mi81-extract_url-1.6.2/bin/extract_url: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/23hk7xnx502nxl8p9j7jsb3f7mhmywmd-perl-5.28.0/bin/perl"
/nix/store/2llyfxfhx6nmkxpwaygmpr6p4bj0mi81-extract_url-1.6.2

jtojnar · 2018-08-25T15:01:41Z

pkgs/applications/misc/extract_url/default.nix

+  makeFlags = "prefix=$(out)";
+
+  postPatch = ''
+    substituteInPlace Makefile --replace /usr/bin/install install


Would not adding INSTALL=install to makeFlags work? It seems to be defined here https://github.com/m3m0ryh0l3/extracturl/blob/422c3c26f7c50b09de6d53748c25d3c905b890d3/Makefile#L71

jtojnar · 2018-08-25T15:02:09Z

pkgs/applications/misc/extract_url/default.nix

+  version = "1.6.2";
+
+  nativeBuildInputs = [ PodChecker makeWrapper ];
+  propagatedBuildInputs = [ perl ] ++ perlDeps;


Why propagate these?

GrahamcOfBorg · 2018-08-25T15:02:26Z

Success on aarch64-linux (full log)

Attempted: extract_url

Partial log (click to expand)

install -m 644 *.1 /nix/store/gdmjg9fkic2162y54qqabrp6s2y8s821-extract_url-1.6.2/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gdmjg9fkic2162y54qqabrp6s2y8s821-extract_url-1.6.2
gzipping man pages under /nix/store/gdmjg9fkic2162y54qqabrp6s2y8s821-extract_url-1.6.2/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gdmjg9fkic2162y54qqabrp6s2y8s821-extract_url-1.6.2/bin
patching script interpreter paths in /nix/store/gdmjg9fkic2162y54qqabrp6s2y8s821-extract_url-1.6.2
/nix/store/gdmjg9fkic2162y54qqabrp6s2y8s821-extract_url-1.6.2/bin/extract_url: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/p3cg3qswdvq6vdjigs83did8km5dlqk7-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/gdmjg9fkic2162y54qqabrp6s2y8s821-extract_url-1.6.2...
/nix/store/gdmjg9fkic2162y54qqabrp6s2y8s821-extract_url-1.6.2

jtojnar · 2018-08-25T15:03:14Z

pkgs/applications/misc/extract_url/default.nix

+  };
+
+  meta = with lib; {
+    homepage = "https://www.memoryhole.net/~kyle/extract_url/";


Plain URLs are preferred unquoted.

I didn't know Nix could do that. Nice! :)

jtojnar · 2018-08-25T21:27:43Z

pkgs/applications/misc/extract_url/default.nix

+  nativeBuildInputs = [ PodChecker makeWrapper ];
+  buildInputs = [ perl ] ++ perlDeps;
+
+  makeFlags = "prefix=$(out)";


These should probably be lists (see #44423)

This seems not to be necessary after all.

xeji · 2018-08-30T15:07:16Z

@GrahamcOfBorg build extract_url

GrahamcOfBorg · 2018-08-30T15:07:53Z

Success on x86_64-darwin (full log)

Attempted: extract_url

Partial log (click to expand)

# install-man
install -m 755 -d /nix/store/7yr8kc8c3gx7r6znx0mgxv3alqvib96w-extract_url-1.6.2/share/man/man1
install -m 644 *.1 /nix/store/7yr8kc8c3gx7r6znx0mgxv3alqvib96w-extract_url-1.6.2/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/7yr8kc8c3gx7r6znx0mgxv3alqvib96w-extract_url-1.6.2/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7yr8kc8c3gx7r6znx0mgxv3alqvib96w-extract_url-1.6.2/bin
patching script interpreter paths in /nix/store/7yr8kc8c3gx7r6znx0mgxv3alqvib96w-extract_url-1.6.2
/nix/store/7yr8kc8c3gx7r6znx0mgxv3alqvib96w-extract_url-1.6.2/bin/extract_url: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/xhir85mv5mfwdkbisnx3bl9h6agjmix4-perl-5.28.0/bin/perl"
/nix/store/7yr8kc8c3gx7r6znx0mgxv3alqvib96w-extract_url-1.6.2

GrahamcOfBorg · 2018-08-30T15:08:09Z

Success on aarch64-linux (full log)

Attempted: extract_url

Partial log (click to expand)

install -m 644 *.1 /nix/store/4fbbjhcz0a6zkbj544a099hmcxa127n7-extract_url-1.6.2/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4fbbjhcz0a6zkbj544a099hmcxa127n7-extract_url-1.6.2
gzipping man pages under /nix/store/4fbbjhcz0a6zkbj544a099hmcxa127n7-extract_url-1.6.2/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4fbbjhcz0a6zkbj544a099hmcxa127n7-extract_url-1.6.2/bin
patching script interpreter paths in /nix/store/4fbbjhcz0a6zkbj544a099hmcxa127n7-extract_url-1.6.2
/nix/store/4fbbjhcz0a6zkbj544a099hmcxa127n7-extract_url-1.6.2/bin/extract_url: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/p3cg3qswdvq6vdjigs83did8km5dlqk7-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/4fbbjhcz0a6zkbj544a099hmcxa127n7-extract_url-1.6.2...
/nix/store/4fbbjhcz0a6zkbj544a099hmcxa127n7-extract_url-1.6.2

GrahamcOfBorg · 2018-08-30T15:08:24Z

Success on x86_64-linux (full log)

Attempted: extract_url

Partial log (click to expand)

install -m 644 *.1 /nix/store/q88pdr4f2kdfz340n06pwx6vcwy4wy7h-extract_url-1.6.2/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q88pdr4f2kdfz340n06pwx6vcwy4wy7h-extract_url-1.6.2
gzipping man pages under /nix/store/q88pdr4f2kdfz340n06pwx6vcwy4wy7h-extract_url-1.6.2/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q88pdr4f2kdfz340n06pwx6vcwy4wy7h-extract_url-1.6.2/bin
patching script interpreter paths in /nix/store/q88pdr4f2kdfz340n06pwx6vcwy4wy7h-extract_url-1.6.2
/nix/store/q88pdr4f2kdfz340n06pwx6vcwy4wy7h-extract_url-1.6.2/bin/extract_url: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/q9ajsngf2w3r10dg7b1148wzq1avp4gj-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/q88pdr4f2kdfz340n06pwx6vcwy4wy7h-extract_url-1.6.2...
/nix/store/q88pdr4f2kdfz340n06pwx6vcwy4wy7h-extract_url-1.6.2

extract_url: init at 1.6.2

744c634

alyssais force-pushed the extract_url branch from 9ca3f23 to 744c634 Compare August 25, 2018 13:31

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 25, 2018

extract_url: purify build

d48ebde

jtojnar reviewed Aug 25, 2018

View reviewed changes

alyssais added 4 commits August 25, 2018 16:21

extract_url: move src to more conventional place

225f027

extract_url: don't unnecessarily propagate

9144790

extract_url: use installFlags instead of patch

69dd4ac

extract_url: use URL literal instead of string

8943078

jtojnar reviewed Aug 25, 2018

View reviewed changes

alyssais added 2 commits August 26, 2018 15:24

extract_url: fix make flags style

9bac9f1

extract_url: remove PodChecker dependency

c61b0c1

This seems not to be necessary after all.

xeji merged commit 7b4c7c4 into NixOS:master Aug 30, 2018

alyssais deleted the extract_url branch September 4, 2018 10:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extract_url: init at 1.6.2 #45624

extract_url: init at 1.6.2 #45624

alyssais commented Aug 25, 2018 •

edited

srhb commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

srhb commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

srhb commented Aug 25, 2018

alyssais commented Aug 25, 2018

srhb commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

jtojnar Aug 25, 2018 •

edited

jtojnar Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

jtojnar Aug 25, 2018

alyssais Aug 25, 2018

jtojnar Aug 25, 2018

xeji commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

extract_url: init at 1.6.2 #45624

extract_url: init at 1.6.2 #45624

Conversation

alyssais commented Aug 25, 2018 • edited

srhb commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

srhb commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

srhb commented Aug 25, 2018

alyssais commented Aug 25, 2018

srhb commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

GrahamcOfBorg commented Aug 25, 2018

jtojnar Aug 25, 2018 • edited

Choose a reason for hiding this comment

jtojnar Aug 25, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Aug 25, 2018

jtojnar Aug 25, 2018

Choose a reason for hiding this comment

alyssais Aug 25, 2018

Choose a reason for hiding this comment

jtojnar Aug 25, 2018

Choose a reason for hiding this comment

xeji commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

GrahamcOfBorg commented Aug 30, 2018

alyssais commented Aug 25, 2018 •

edited

jtojnar Aug 25, 2018 •

edited