Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apmplanner2: fixed wrong path in .desktop file #45609

Merged
merged 1 commit into from Aug 24, 2018
Merged

apmplanner2: fixed wrong path in .desktop file #45609

merged 1 commit into from Aug 24, 2018

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Aug 24, 2018 •
edited

Motivation for this change

The apmplanner2.desktop file defaults to /usr/share/... regardless which out
prefix is given to make. So I chose to fix it manually.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@wucke13
apmplanner2: fixed wrong path in .desktop file
b7e6954 
The `apmplanner2.desktop` file defaults to `/usr/share/...` regardless which out
prefix is given to make. So I chose to fix it manually.
infinisil
infinisil approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@infinisil infinisil merged commit ea6279c into NixOS:master Aug 24, 2018
@wucke13 wucke13 deleted the apmplanner2 branch August 30, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wucke13 @infinisil @GrahamcOfBorg