Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/matrix-synapse: fix test #45596

Merged
merged 1 commit into from Aug 26, 2018
Merged

nixos/tests/matrix-synapse: fix test #45596

merged 1 commit into from Aug 26, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Aug 24, 2018 •
edited

Motivation for this change

Since matrix-synapse was upgraded to 0.33.0, underscores in server names are rejected by server name validation, causing the test to fail on hydra:
valueError: Server name 'server_sqlite' contains invalid characters
Relevant upstream change: matrix-org/synapse@546bc9e

Not sure if this is an upstream bug or a deliberate decision, filed matrix-org/synapse#3759 to check.

Anyway, we can just fix the tests by using server names without underscores.

Things done
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@xeji
nixos/tests/matrix-synapse: fix test
f61de14 
Since matrix-synapse 0.33.0 underscores in server names are rejected
by server name validation, causing the test to fail:
  valueError: Server name 'server_sqlite' contains invalid characters
Relevant upstream change:
matrix-org/synapse@546bc9e
@xeji
Copy link
Contributor Author

xeji commented Aug 24, 2018

@GrahamcOfBorg test matrix-synapse

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

cannot build derivation '/nix/store/x49xywv7rbvis4zchqnidwmm4z8082nl-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1cnq1d170fds9v9a8vrwdhgpx4wm7v6j-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vzfwnhhzj5xqf7vy3mb667sj3fm9kkni-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6a1rngzmnh3h0b2rj795wjlhms47i9mv-nixos-system-serversqlite-18.09.git.3535dda.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/0sximz453m725kbm0a8nsnwvmh0brjka-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ynhjiglix7li3pp3nnw3222wwsw0dz3s-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/pglcwssvywn0r0njp6lvsihhqp7akj6g-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/cx5k319zl6w5nn8cblyhgbd8hs0y792c-nixos-test-driver-matrix-synapse.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6mxcc12rmjzvlbxxyl8a4hlrw58bvwm8-vm-test-run-matrix-synapse.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6mxcc12rmjzvlbxxyl8a4hlrw58bvwm8-vm-test-run-matrix-synapse.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Aug 24, 2018

Timeout because of a kernel update, let's wait and try again later.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serversqlite# [  267.727708] synapse[788]: synapse.storage.background_updates: [] Adding index access_tokens_device_id to access_tokens
serversqlite# [  267.749789] synapse[788]: synapse.storage.background_updates: [] Updating u'access_tokens_device_index'. Updated 1 items in 34ms. (total_rate=None/ms, current_rate=None/ms, total_updated=0, batch_size=100)
serversqlite: exit status 0
test script finished in 272.74s
cleaning up
killing serverpostgres (pid 631)
killing serversqlite (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/mlkzsx2svhcfzi57a8i5ljb6m4m0z1as-vm-test-run-matrix-synapse

@xeji
Copy link
Contributor Author

xeji commented Aug 24, 2018

@GrahamcOfBorg test matrix-synapse

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serverpostgres: exit status 0
serversqlite: running command: sync
serversqlite: exit status 0
test script finished in 116.25s
cleaning up
killing serverpostgres (pid 631)
killing serversqlite (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/lval0kd9pqq0j5jkmyr6mdzkqry739mw-vm-test-run-matrix-synapse

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serverpostgres# [  292.325043] sudo[707]: pam_unix(sudo:session): session closed for user postgres
error: timed out waiting for the VM to connect
timed out waiting for the VM to connect
cleaning up
killing serversqlite (pid 600)
killing serverpostgres (pid 612)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/zw22p3inaw2zal514h3b9mqnnj9zy5ws-vm-test-run-matrix-synapse.drv' failed with exit code 4
error: build of '/nix/store/zw22p3inaw2zal514h3b9mqnnj9zy5ws-vm-test-run-matrix-synapse.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Aug 24, 2018

error: timed out waiting for the VM to connect
looks more like issue related to the ofborg builder. Same thing happened to me with another test a few minutes ago. Test succeeds locally, will try again on ofborg later.

@xeji xeji mentioned this pull request Aug 24, 2018
Closed
41 tasks
srhb
srhb approved these changes Aug 25, 2018
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine here as well, looks good :)

@xeji
Copy link
Contributor Author

xeji commented Aug 26, 2018

@GrahamcOfBorg test matrix-synapse

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serverpostgres: running command: sync
serverpostgres# [  114.616315] synapse[1173]: synapse.storage.background_updates: [] Updating u'user_ips_device_index'. Updated 1 items in 18ms. (total_rate=None/ms, current_rate=None/ms, total_updated=0, batch_size=100)
serverpostgres: exit status 0
test script finished in 116.17s
cleaning up
killing serversqlite (pid 631)
killing serverpostgres (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/fcn8r5v67m132wbhy8957d4gkjbv8rd1-vm-test-run-matrix-synapse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serversqlite: exit status 0
serverpostgres: running command: sync
serverpostgres: exit status 0
test script finished in 136.13s
cleaning up
killing serversqlite (pid 597)
killing serverpostgres (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/sk67p4bnapwib9ifzhcv78drjfwg9282-vm-test-run-matrix-synapse

@xeji xeji merged commit 3050406 into NixOS:master Aug 26, 2018
@xeji xeji deleted the patch/matrix-synapse-test branch August 26, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @srhb