vk-messenger: init #45605
vk-messenger: init #45605
Conversation
| src = { | ||
| name = "${name}.deb"; | ||
| i686-linux = fetchurl { | ||
| url = "https://desktop.userapi.com/get_last?platform=linux32&branch=master&packet=deb"; |
There was a problem hiding this comment.
get_last? master?? The hash will change which will break the package.
There was a problem hiding this comment.
@dotlambda ok, I'll try to find packages archives
There was a problem hiding this comment.
@dotlambda
As of official urls
https://desktop.userapi.com/debian/pool/master/v/vk/
https://desktop.userapi.com/rpm/master/
https://desktop.userapi.com/linux64/master/
Only https://desktop.userapi.com/rpm/master/ keeps archives so I took that one. Unfortunately it doesn't ship arm version, so I dropped support for arm
| meta = with stdenv.lib; { | ||
| description = "Simple and Convenient Messaging App for VK"; | ||
| homepage = https://vk.com/messenger; | ||
| license = licenses.free; |
There was a problem hiding this comment.
@dotlambda this is not right, but VK Messenger doesn't really have a defined license
There was a problem hiding this comment.
@dotlambda @Yardanico dunno what license it has. Inside the package by share/doc/vk/copyright path there is
Copyright (c) 2013-2017 GitHub Inc.
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
There was a problem hiding this comment.
Well, VK Messenger is certainly not made by GitHub. That doesn't seem to be the correct license. And unless you know where to find the source, it's certainly unfree.
| stdenv.mkDerivation rec { | ||
| name = "vk-messenger-3.9.0"; | ||
| src = { | ||
| name = "${name}.deb"; |
It's another package I maintain, also electron based. Why not touch it while there? |
Do so in a separate PR. |
|
@dotlambda Fixed, thanks! |
|
@matthewbauer Thanks! |
ghost
deleted the
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)