Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pam_ldap,nss_ldap: fix build #45607

Merged
merged 2 commits into from Aug 24, 2018
Merged

pam_ldap,nss_ldap: fix build #45607

merged 2 commits into from Aug 24, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Aug 24, 2018

Motivation for this change

Builds failed for nss_ldap and pam_ldap.

An upstream perl script needed during build wasn't found, fix path

This also fixes the nixos/tests/ldap test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
pam_ldap: fix build
9a31b8c 
an upstream perl script needed during build wasn't found, fix path
@xeji
nss_ldap: fix build
9a05740 
an upstream perl script needed during build wasn't found, fix path
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pam_ldap

The following builds were skipped because they don't evaluate on x86_64-darwin: nss_ldap

Partial log (click to expand)

test -z "/nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186/man/man5" || mkdir -p -- "/nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186/man/man5"
 /nix/store/s1611b09rakv7k80gb4x66fi3hgpbnn1-coreutils-8.29/bin/install -c -m 644 './pam_ldap.5' '/nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186/man/man5/pam_ldap.5'
make[1]: Leaving directory '/private/tmp/nix-build-pam_ldap-186.drv-0/pam_ldap-186'
post-installation fixup
moving /nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186/man to /nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186/share/man
gzipping man pages under /nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186/share/man/
strip is /nix/store/vvbmqsh5ikrxkiwj71dwfbzcwf4bfav8-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186/lib
patching script interpreter paths in /nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186
/nix/store/28zcgkdrck5mpncfc64rphlsf52px3lk-pam_ldap-186

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nss_ldap, pam_ldap

Partial log (click to expand)

moving /nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186/man to /nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186
shrinking /nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186/lib/security/pam_ldap.so
gzipping man pages under /nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186/lib
patching script interpreter paths in /nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186
checking for references to /build in /nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186...
/nix/store/g18m20zlna26b064cam7adbdlrbsqmzg-nss_ldap-265
/nix/store/64xknr3pkkm3pymx44aknljw350s9fsf-pam_ldap-186

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nss_ldap, pam_ldap

Partial log (click to expand)

moving /nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265/man to /nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265
shrinking /nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265/lib/libnss_ldap-2.5.so
gzipping man pages under /nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265/lib
patching script interpreter paths in /nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265
checking for references to /build in /nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265...
/nix/store/sa68q73cb4i9xxp05qm2nc2l036i267a-nss_ldap-265
/nix/store/j0iw5mpwg96y1cyhl1dzh470ycm0i86i-pam_ldap-186

@xeji
Copy link
Contributor Author

xeji commented Aug 24, 2018

@GrahamcOfBorg test ldap

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.ldap

Partial log (click to expand)

server: exit status 0
2 out of 2 tests succeeded
test script finished in 26.31s
cleaning up
killing client2 (pid 631)
killing client1 (pid 643)
killing server (pid 656)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/krfiwrzlxdshhfm6pd8r80az91a8hw1x-vm-test-run-ldap

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.ldap

Partial log (click to expand)

error: timed out waiting for the VM to connect
timed out waiting for the VM to connect
cleaning up
killing client2 (pid 600)
killing client1 (pid 612)
killing server (pid 624)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/knv5gccimhmy3kn3xm8l8dg8aljgqlna-vm-test-run-ldap.drv' failed with exit code 4
error: build of '/nix/store/knv5gccimhmy3kn3xm8l8dg8aljgqlna-vm-test-run-ldap.drv' failed

@globin
Copy link
Member

globin commented Aug 24, 2018

@GrahamcOfBorg test ldap

@xeji
Copy link
Contributor Author

xeji commented Aug 24, 2018

test succeeds locally

@globin globin merged commit 519012b into NixOS:master Aug 24, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.ldap

Partial log (click to expand)

server: running command: sync
server: exit status 0
2 out of 2 tests succeeded
test script finished in 23.81s
cleaning up
killing client1 (pid 597)
killing client2 (pid 609)
killing server (pid 621)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.ldap

Partial log (click to expand)

client1: exit status 0
2 out of 2 tests succeeded
test script finished in 25.93s
cleaning up
killing client2 (pid 631)
killing server (pid 643)
killing client1 (pid 656)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/i2gii3a137p5k4vh31pkmrlxcnynnaq5-vm-test-run-ldap

@xeji xeji deleted the patch/pam-ldap branch August 24, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @globin