Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/munin: fix non-deterministic failure #45622

Merged
merged 1 commit into from Aug 25, 2018
Merged

nixos/tests/munin: fix non-deterministic failure #45622

merged 1 commit into from Aug 25, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Aug 25, 2018

Motivation for this change

The test failed (non-deterministically) on hydra due to a timing issue: the node wasn't listening yet when munin-cron service was started.

To make the test more reliable:

  • wait for node to listen on its port before starting munin-cron
  • increase timeout for munin-cron startup to prevent failure under high load
  • disable a failing plugin to remove irrelevant error messages
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@xeji
nixos/tests/munin: fix non-deterministic failure
268bb4e 
- wait for node to listen before starting munin-cron
- increase timeout for munin-cron startup
- disable a failing plugin to remove irrelevant error message
@infinisil
Copy link
Member

@GrahamcOfBorg test munin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.munin

Partial log (click to expand)

one: exit status 1
syncing
one: running command: sync
one: exit status 0
test script finished in 32.81s
cleaning up
killing one (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/l009a408j4pp7d86fr6xz8anxk4m2x58-vm-test-run-munin

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.munin

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@srhb srhb merged commit 6b709c5 into NixOS:master Aug 25, 2018
@xeji xeji deleted the p/munin-test branch August 25, 2018 13:47
@xeji xeji mentioned this pull request Sep 18, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @infinisil @GrahamcOfBorg @srhb